1 |
Hi Mike, |
2 |
|
3 |
I've tesed Kevin Zhao's patches Could you help me to review v3 patches |
4 |
and merge to upstream ? |
5 |
These patches will be sent in mail list later.... Thanks |
6 |
|
7 |
*Leno Hou* |
8 |
|
9 |
On Tue, Jan 12, 2016 at 10:31 PM, Kevin Zhao <kevin.zhaoshuai@×××××.com> |
10 |
wrote: |
11 |
|
12 |
> Hi Mike, |
13 |
> Thanks for your comment.I have send a new patch cover this :-) |
14 |
> |
15 |
> 2016-01-09 3:50 GMT+08:00 Mike Frysinger <vapier@g.o>: |
16 |
> > On 08 Jan 2016 05:04, Kevin Zhao wrote: |
17 |
> >> + if echo ${clst_subarch} | grep -qE ".+le$" |
18 |
> > |
19 |
> > just use a pattern match: |
20 |
> > if [[ ${clst_subarch} == *le ]] |
21 |
> > |
22 |
> >> + then |
23 |
> >> + flags+=( |
24 |
> >> + -v -T -l -cache-inodes -chrp-boot |
25 |
> >> + ) |
26 |
> > |
27 |
> > -chrp-boot shows up in both, so factor that out into the common setting ? |
28 |
> > |
29 |
> >> + flags+=( |
30 |
> >> + -chrp-boot -netatalk -hfs -probe -map |
31 |
> "${clst_target_path}"/boot/map.hfs \ |
32 |
> > |
33 |
> > you don't need to use \ with arrays |
34 |
> > -mike |
35 |
> |
36 |
> |