| 1 |
On Thu, May 21, 2020 at 10:34 AM Daniel Cordero <gentoo.catalyst@××××.ws> wrote: |
| 2 |
> |
| 3 |
> From: Daniel Cordero <catalyst@××××.io> |
| 4 |
> |
| 5 |
> dir_setup() doesn't exist, bootloader() exists but requires specific |
| 6 |
> tools to be installed in the seed stage and doesn't check that they are, |
| 7 |
> causing the build to fail. |
| 8 |
> --- |
| 9 |
> If I have misconstrued the purpose of bootloader, then documentation |
| 10 |
> needs to be written. |
| 11 |
|
| 12 |
I don't actually see any documentation about |
| 13 |
> catalyst/targets/embedded.py | 2 -- |
| 14 |
> 1 file changed, 2 deletions(-) |
| 15 |
> |
| 16 |
> diff --git a/catalyst/targets/embedded.py b/catalyst/targets/embedded.py |
| 17 |
> index aa23f5b3..1b4ad9d6 100644 |
| 18 |
> --- a/catalyst/targets/embedded.py |
| 19 |
> +++ b/catalyst/targets/embedded.py |
| 20 |
> @@ -41,7 +41,6 @@ class embedded(StageBase): |
| 21 |
> |
| 22 |
> def set_action_sequence(self): |
| 23 |
> self.settings['action_sequence'] = [ |
| 24 |
> - "dir_setup", |
| 25 |
|
| 26 |
Nice. This function was removed in 2005, so the embedded target has |
| 27 |
been broken ever since. That certainly answers my question as to |
| 28 |
whether anyone uses it. |
| 29 |
|
| 30 |
Fixes: 1dafb5fa06d2 (Add locking support. ...) |
| 31 |
|
| 32 |
So, you must use the embedded target. Could you tell me how you use |
| 33 |
it, for what device, etc? |
| 34 |
|
| 35 |
> "unpack", |
| 36 |
> "config_profile_link", |
| 37 |
> "setup_confdir", |
| 38 |
> @@ -51,7 +50,6 @@ class embedded(StageBase): |
| 39 |
> "setup_environment", |
| 40 |
> "build_kernel", |
| 41 |
> "build_packages", |
| 42 |
> - "bootloader", |
| 43 |
|
| 44 |
It's not obvious to me what specific tools this requires to be |
| 45 |
installed in the seed stage. Presumably you're referring to this? |
| 46 |
|
| 47 |
cmd([self.settings['controller_file'], 'bootloader', |
| 48 |
self.settings['target_path'].rstrip('/')] |
| 49 |
|
| 50 |
which eventually runs bootloader-setup.sh. |
| 51 |
|
| 52 |
I'd assume it's generally sensible to install a bootloader in the |
| 53 |
embedded target, and I don't think we have mechanism for customizing |
| 54 |
the action_sequence, so if we remove bootloader from the list then I |
| 55 |
think the python bootloader() function is just dead code, isn't it? I |
| 56 |
doubt that's the end result we want. |
Archives