Gentoo Archives: gentoo-catalyst

From: Mike Frysinger <vapier@g.o>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] RFC: [PATCH]: Test for presence of distcc before preclean to avoid failure
Date: Wed, 24 Jan 2018 03:45:10
Message-Id: 20180124034506.GA1731@vapier
In Reply to: [gentoo-catalyst] RFC: [PATCH]: Test for presence of distcc before preclean to avoid failure by "M. J. Everitt"
1 On 24 Jan 2018 00:13, M. J. Everitt wrote:
2 > --- a/targets/stage3/stage3-preclean-chroot.sh
3 > +++ b/targets/stage3/stage3-preclean-chroot.sh
4 > @@ -11,7 +11,10 @@ cleanup_stages
5 >
6 > if [ -n "${clst_DISTCC}" ]
7 > then
8 > - run_merge -C sys-devel/distcc || exit 1
9 > + portageq match / sys-devel/distcc 2>&1 | grep -s -q distcc
10
11 just do a -n test on the output instead
12
13 although seems like portageq should be better with its exit status
14
15 > + if [ $? == 0 ]; then
16
17 use `[[` instead of `[` when writing bash, especially when using
18 bash code like "==".
19 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies