Gentoo Archives: gentoo-catalyst

From: Matt Turner <mattst88@g.o>
To: gentoo-catalyst@l.g.o
Cc: Matt Turner <mattst88@g.o>
Subject: [gentoo-catalyst] [PATCH 1/2] catalyst: Remove clear_dir's never used clear_nondir parameter
Date: Thu, 10 Jun 2021 03:28:49
Message-Id: 20210610032840.466809-1-mattst88@gentoo.org
1 Signed-off-by: Matt Turner <mattst88@g.o>
2 ---
3 catalyst/fileops.py | 11 +++--------
4 1 file changed, 3 insertions(+), 8 deletions(-)
5
6 diff --git a/catalyst/fileops.py b/catalyst/fileops.py
7 index 59525420..4252285e 100644
8 --- a/catalyst/fileops.py
9 +++ b/catalyst/fileops.py
10 @@ -46,8 +46,7 @@ def ensure_dirs(path, gid=-1, uid=-1, mode=0o755, minimal=True,
11 return succeeded
12
13
14 -def clear_dir(target, mode=0o755, remove=False,
15 - clear_nondir=True):
16 +def clear_dir(target, mode=0o755, remove=False):
17 '''Universal directory clearing function
18
19 @target: string, path to be cleared or removed
20 @@ -74,12 +73,8 @@ def clear_dir(target, mode=0o755, remove=False,
21 log.error('clear_dir failed', exc_info=True)
22 return False
23 elif os.path.exists(target):
24 - if clear_nondir:
25 - log.debug("Clearing (unlinking) non-directory: %s", target)
26 - os.unlink(target)
27 - else:
28 - log.info('clear_dir failed: %s: is not a directory', target)
29 - return False
30 + log.debug("Clearing (unlinking) non-directory: %s", target)
31 + os.unlink(target)
32 else:
33 log.debug("Conditions not met to clear: %s", target)
34 log.debug(" isdir: %s", os.path.isdir(target))
35 --
36 2.31.1

Replies