Gentoo Archives: gentoo-catalyst

From: "W. Trevor King" <wking@×××××××.us>
To: gentoo-catalyst@l.g.o
Cc: "W. Trevor King" <wking@×××××××.us>
Subject: [gentoo-catalyst] [PATCH] Makefile: Fix PACKAGE_VERSION extraction
Date: Sat, 22 Feb 2014 19:39:17
Message-Id: 575419cef3b2b642000683bf2cae049b069d0b75.1393097745.git.wking@tremily.us
In Reply to: [gentoo-catalyst] [PATCH 1/5] Initial rearrangement of the python directories by Brian Dolbec
1 The old method grepped for __version__ in catalyst. That broke with
2 24c5352 (Initial rearrangement of the python directories, 2013-01-10),
3 which moved catalyst to bin/catalyst, kept the __version__ in
4 bin/catalyst, and added a new __version__ in catalyst/main.py. Then
5 46b261e (setup.py: Add disutils-based packaging, 2013-06-05)
6 consolidated the __version__ definitions in catalyst/__init__.py,
7 removing them from bin/catalyst and catalyst/main.py. This patch
8 adjusts the Makefile, invoking Python to extract catalyst.__version__
9 instead of grepping through the file that defines it.
10 ---
11 This patch is in git://tremily.us/catalyst.git setup-py as 575419c.
12
13 Makefile | 2 +-
14 1 file changed, 1 insertion(+), 1 deletion(-)
15
16 diff --git a/Makefile b/Makefile
17 index 98accbe..757113c 100644
18 --- a/Makefile
19 +++ b/Makefile
20 @@ -1,7 +1,7 @@
21 # Copyright (C) 2011 Sebastian Pipping <sebastian@×××××××.org>
22 # Licensed under GPL v2 or later
23
24 -PACKAGE_VERSION = `fgrep '__version__=' catalyst | sed 's|^__version__="\(.*\)"$$|\1|'`
25 +PACKAGE_VERSION = $(shell PYTHONPATH=. python -c 'import catalyst; print(catalyst.__version__)')
26 MAN_PAGE_SOURCES = $(wildcard doc/*.?.txt)
27 MAN_PAGES = $(patsubst doc/%.txt,files/%,$(MAN_PAGE_SOURCES))
28 MAN_PAGE_INCLUDES = doc/subarches.generated.txt doc/targets.generated.txt
29 --
30 1.8.5.2.8.g0f6c0d1

Replies