Gentoo Archives: gentoo-catalyst

From: "W. Trevor King" <wking@×××××××.us>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] [PATCH v3 5/6] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary
Date: Fri, 03 Jan 2014 04:47:40
Message-Id: 20140103044734.GF4680@odin.tremily.us
In Reply to: [gentoo-catalyst] [PATCH v3 5/6] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary by Brian Dolbec
1 On Thu, Jan 02, 2014 at 08:16:21PM -0800, Brian Dolbec wrote:
2 > Temporary location to define TARGET_MOUNTS_DEFAULTS.
3 > It will be moved to a new defaults.py file in a later commit.
4 > I also plan to make them configurable.
5 >
6 > Also:
7 > * Clean up all self.mounts, self.mountmap usage.
8 > * Replace multiple path additions with one instance at the
9 > beginning of the function, reuse the result multiple times.
10 > * Add some extra debug prints (to be converted to logging later)
11
12 Commit message looks great. The content is the same as v2, so I like
13 it.
14
15 Cheers,
16 Trevor
17
18 --
19 This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
20 For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Attachments

File name MIME type
signature.asc application/pgp-signature