Gentoo Archives: gentoo-catalyst

From: Mike Frysinger <vapier@g.o>
To: gentoo-catalyst@l.g.o
Subject: [gentoo-catalyst] [PATCH] lint: clean up unused imports
Date: Tue, 06 Oct 2015 04:05:56
Message-Id: 1444104350-15916-1-git-send-email-vapier@gentoo.org
1 Delete imports that the modules don't actually utilize.
2 ---
3 catalyst/base/resume.py | 2 --
4 catalyst/fileops.py | 2 ++
5 catalyst/targets/grp.py | 3 +--
6 catalyst/targets/livecd_stage1.py | 3 +--
7 catalyst/targets/livecd_stage2.py | 3 +--
8 catalyst/targets/netboot2.py | 3 +--
9 6 files changed, 6 insertions(+), 10 deletions(-)
10
11 diff --git a/catalyst/base/resume.py b/catalyst/base/resume.py
12 index a03adf3..608f574 100644
13 --- a/catalyst/base/resume.py
14 +++ b/catalyst/base/resume.py
15 @@ -12,8 +12,6 @@ set, unset, is_set, is_unset, enabled, clear_all
16 '''
17
18 import os
19 -import shutil
20 -from stat import ST_UID, ST_GID, ST_MODE
21 import sys
22 import traceback
23
24 diff --git a/catalyst/fileops.py b/catalyst/fileops.py
25 index 129d967..8a05985 100644
26 --- a/catalyst/fileops.py
27 +++ b/catalyst/fileops.py
28 @@ -16,8 +16,10 @@ from stat import ST_UID, ST_GID, ST_MODE
29
30 # NOTE: pjoin and listdir_files are imported here for export
31 # to other catalyst modules
32 +# pylint: disable=unused-import
33 from snakeoil.osutils import (ensure_dirs as snakeoil_ensure_dirs,
34 pjoin, listdir_files)
35 +# pylint: enable=unused-import
36 from catalyst.support import CatalystError
37
38
39 diff --git a/catalyst/targets/grp.py b/catalyst/targets/grp.py
40 index 5a10fff..4814ac6 100644
41 --- a/catalyst/targets/grp.py
42 +++ b/catalyst/targets/grp.py
43 @@ -8,8 +8,7 @@ import types
44 import glob
45
46
47 -from catalyst.support import (CatalystError, normpath,
48 - touch, cmd, list_bashify)
49 +from catalyst.support import (CatalystError, normpath, cmd, list_bashify)
50 from catalyst.fileops import ensure_dirs
51 from catalyst.base.stagebase import StageBase
52
53 diff --git a/catalyst/targets/livecd_stage1.py b/catalyst/targets/livecd_stage1.py
54 index af59ed7..1930df1 100644
55 --- a/catalyst/targets/livecd_stage1.py
56 +++ b/catalyst/targets/livecd_stage1.py
57 @@ -7,8 +7,7 @@ import os
58 import types
59
60
61 -from catalyst.support import (normpath,
62 - touch, cmd)
63 +from catalyst.support import (normpath, cmd)
64 from catalyst.fileops import ensure_dirs
65
66 from catalyst.base.stagebase import StageBase
67 diff --git a/catalyst/targets/livecd_stage2.py b/catalyst/targets/livecd_stage2.py
68 index 77c6613..870dcf9 100644
69 --- a/catalyst/targets/livecd_stage2.py
70 +++ b/catalyst/targets/livecd_stage2.py
71 @@ -5,8 +5,7 @@ LiveCD stage2 target, builds upon previous LiveCD stage1 tarball
72
73 import os
74
75 -from catalyst.support import (normpath, file_locate, CatalystError, cmd,
76 - read_from_clst, touch)
77 +from catalyst.support import (normpath, file_locate, CatalystError, cmd)
78 from catalyst.fileops import ensure_dirs
79 from catalyst.base.stagebase import StageBase
80
81 diff --git a/catalyst/targets/netboot2.py b/catalyst/targets/netboot2.py
82 index 3305a2a..5de1a74 100644
83 --- a/catalyst/targets/netboot2.py
84 +++ b/catalyst/targets/netboot2.py
85 @@ -8,8 +8,7 @@ import types
86 import shutil
87 from stat import ST_UID, ST_GID, ST_MODE
88
89 -from catalyst.support import (CatalystError, normpath,
90 - touch, cmd, list_bashify)
91 +from catalyst.support import (CatalystError, normpath, cmd, list_bashify)
92 from catalyst.fileops import ensure_dirs
93
94 from catalyst.base.stagebase import StageBase
95 --
96 2.5.2

Replies

Subject Author
Re: [gentoo-catalyst] [PATCH] lint: clean up unused imports Brian Dolbec <dolsen@g.o>