| 1 |
On Mon, 1 Sep 2014 22:06:34 -0700 |
| 2 |
"W. Trevor King" <wking@×××××××.us> wrote: |
| 3 |
|
| 4 |
> On Mon, Sep 01, 2014 at 07:31:41PM -0700, Brian Dolbec wrote: |
| 5 |
> > Conflicts: |
| 6 |
> > targets/support/functions.sh |
| 7 |
> |
| 8 |
> Presumably these are conflicts from rebasing from 3.0. I don't think |
| 9 |
> we care about those, so I'd remove this note from the commit message. |
| 10 |
> |
| 11 |
> What are the symptoms of the bug this fixes? How do I trigger it in |
| 12 |
> Catalysts without this patch? |
| 13 |
> |
| 14 |
> Cheers, |
| 15 |
> Trevor |
| 16 |
> |
| 17 |
|
| 18 |
Yeah, sorry, I was leaving those in place while fixing rebase errors... |
| 19 |
it helps to find them. I'll clean them out once review is done. |
| 20 |
|
| 21 |
This is only half the original problem. The other half is fixed in a |
| 22 |
previous commit. What it orginally did was assign destdir with a |
| 23 |
leading '.' then when I made some other seemingly unrelated change, |
| 24 |
moving the '.' from the assignment to the usage fixed the relative path |
| 25 |
issue. It drove me nuts trying to find it. |
| 26 |
|
| 27 |
-- |
| 28 |
Brian Dolbec <dolsen> |
Archives