| 1 |
On Sat, 2013-12-14 at 06:54 -0800, Dylan Baker wrote: |
| 2 |
> On Friday, December 13, 2013 07:07:15 PM Brian Dolbec wrote: |
| 3 |
> > --- |
| 4 |
> > modules/generic_stage_target.py | 6 +++--- |
| 5 |
> > 1 file changed, 3 insertions(+), 3 deletions(-) |
| 6 |
> > |
| 7 |
> > diff --git a/modules/generic_stage_target.py |
| 8 |
> > b/modules/generic_stage_target.py index 342c65b..1fbc733 100644 |
| 9 |
> > --- a/modules/generic_stage_target.py |
| 10 |
> > +++ b/modules/generic_stage_target.py |
| 11 |
> > @@ -1066,9 +1066,9 @@ class generic_stage_target(generic_target): |
| 12 |
> > "/use will cause portage to ignore" |
| 13 |
> > print "\tpackage.use in the profile and portage_confdir. |
| 14 |
> You've been |
| 15 |
> > warned!" |
| 16 |
> > |
| 17 |
> > - myf.write('PORTDIR="/usr/portage"\n') |
| 18 |
> > - myf.write('DISTDIR="${PORTDIR}/distfiles"\n') |
| 19 |
> > - myf.write('PKGDIR="${PORTDIR}/packages"\n') |
| 20 |
> > + myf.write('PORTDIR="%s"\n' % self.settings['portdir']) |
| 21 |
> > + myf.write('DISTDIR="%s"\n' % self.settings['distdir']) |
| 22 |
> > + myf.write('PKGDIR="%s"\n' % self.settings['packagedir']) |
| 23 |
> |
| 24 |
> what is the point of this? These produce exactly the same output, except the |
| 25 |
> previous is more readable. |
| 26 |
> |
| 27 |
Sure it is more readable in that one spot. BUT... |
| 28 |
The point is the entire reason for the whole re-write I started in the |
| 29 |
first place. Removing hard coded paths scattered throughout the code. |
| 30 |
Putting them in one easily modified and maintainable place. |
| 31 |
|
| 32 |
> > |
| 33 |
> > """ Setup the portage overlay """ |
| 34 |
> > if "portage_overlay" in self.settings: |
Archives