[gentoo-catalyst] Re: [PATCH] make.conf and make.profile moved to /etc/portage so stop cleaning it to avoid multiple fatal errors

[Richard Farina]

Sorry that was a little iffy on the git send email, it's been a while.

An example of some of the errors solved by this patch is :
http://slexy.org/view/s20oDYzxrC

I was completely unable to build stage2 before this change (and stage1
completed but was REALLY ugly at the end).

Has anyone else run into this yet? I mean the issue can't get much more
obvious, we clean out /etc/portage near the end of each stage but
/etc/portage/make.conf and /etc/portage/make.profile are rather required....

Thanks!

-Zero

On 07/27/2012 04:57 AM, Rick Farina wrote:
> Signed-off-by: Rick Farina <sidhayn@×××××.com>
> ---
>  modules/stage1_target.py |    3 +--
>  modules/stage2_target.py |    1 -
>  2 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/modules/stage1_target.py b/modules/stage1_target.py
> index 32e6334..560efdb 100644
> --- a/modules/stage1_target.py
> +++ b/modules/stage1_target.py
> @@ -31,8 +31,7 @@ class stage1_target(generic_stage_target):
>  		"/usr/lib/python2.2/lib-tk", "/usr/lib/python2.3/test",\
>  		"/usr/lib/python2.3/email", "/usr/lib/python2.3/lib-tk",\
>  		"/usr/lib/python2.4/test", "/usr/lib/python2.4/email",\
> -		"/usr/lib/python2.4/lib-tk", "/usr/share/zoneinfo",\
> -		"/etc/portage"])
> +		"/usr/lib/python2.4/lib-tk", "/usr/share/zoneinfo"])
>
>  	# XXX: How do these override_foo() functions differ from the ones in generic_stage_target and why aren't they in stage3_target?
>
> diff --git a/modules/stage2_target.py b/modules/stage2_target.py
> index f529721..97ea7fe 100644
> --- a/modules/stage2_target.py
> +++ b/modules/stage2_target.py
> @@ -35,7 +35,6 @@ class stage2_target(generic_stage_target):
>
>  	def set_cleanables(self):
>  		generic_stage_target.set_cleanables(self)
> -		self.settings["cleanables"].extend(["/etc/portage"])
>
>  	def override_chost(self):
>  		if self.settings.has_key("chost"):