Re: [gentoo-catalyst] [PATCH 3/4] Adapt commit c52962b6bd2 to use the new configured settings values.

[Dylan Baker]

Please ignore my last email. I should drink my coffee *before* I begin
reviewing patches.


On Sat, Dec 14, 2013 at 6:54 AM, Dylan Baker <baker.dylan.c@×××××.com>wrote:

> On Friday, December 13, 2013 07:07:15 PM Brian Dolbec wrote:
> > ---
> >  modules/generic_stage_target.py | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/modules/generic_stage_target.py
> > b/modules/generic_stage_target.py index 342c65b..1fbc733 100644
> > --- a/modules/generic_stage_target.py
> > +++ b/modules/generic_stage_target.py
> > @@ -1066,9 +1066,9 @@ class generic_stage_target(generic_target):
> >                                               "/use will cause portage
> to ignore"
> >                                       print "\tpackage.use in the
> profile and portage_confdir.
> You've been
> > warned!"
> >
> > -                     myf.write('PORTDIR="/usr/portage"\n')
> > -                     myf.write('DISTDIR="${PORTDIR}/distfiles"\n')
> > -                     myf.write('PKGDIR="${PORTDIR}/packages"\n')
> > +                     myf.write('PORTDIR="%s"\n' %
> self.settings['portdir'])
> > +                     myf.write('DISTDIR="%s"\n' %
> self.settings['distdir'])
> > +                     myf.write('PKGDIR="%s"\n' %
> self.settings['packagedir'])
>
> what is the point of this? These produce exactly the same output, except
> the
> previous is more readable.
>
> >
> >                       """ Setup the portage overlay """
> >                       if "portage_overlay" in self.settings:
>