1 |
On Sat, Dec 28, 2013 at 05:57:05PM -0800, Brian Dolbec wrote: |
2 |
> Subject: Re: [gentoo-catalyst] [PATCH 1/6] modules/generic_stage_target.py: |
3 |
> USE portdir, distdir,... instead of paths for keys |
4 |
|
5 |
I'd prefer “: Use” instead of “: USE”. |
6 |
|
7 |
> - self.mounts=["/proc","/dev","/usr/portage","/usr/portage/distfiles","/var/tmp/portage"] |
8 |
> - self.mountmap={"/proc":"/proc","/dev":"/dev","devpts":"/dev/pts", |
9 |
> - "/usr/portage":self.settings["snapshot_cache_path"]+"/portage",\ |
10 |
> - "/usr/portage/distfiles":self.settings["distdir"],"/var/tmp/portage":"tmpfs"} |
11 |
> + self.mounts=["proc", "dev", "portdir", "distdir", "port_tmpdir"] |
12 |
> + self.mountmap={"proc":"/proc", "dev":"/dev", "devpts":"/dev/pts", |
13 |
> + "portdir":self.settings["snapshot_cache_path"]+"/portage",\ |
14 |
> + "distdir":self.settings["distdir"],"port_tmpdir":"tmpfs"} |
15 |
|
16 |
No need for the backslash after “"/portage",”. There should also |
17 |
probably be a space before “"port_tmpdir"”. Style issues asside, the |
18 |
content looks good to me. |
19 |
|
20 |
Cheers, |
21 |
Trevor |
22 |
|
23 |
-- |
24 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
25 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |