Gentoo Archives: gentoo-catalyst

From: "W. Trevor King" <wking@×××××××.us>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] [PATCH 6/6] Set mountmap["icecream"] from settings for now.
Date: Sun, 29 Dec 2013 02:53:20
Message-Id: 20131229025316.GI29195@odin.tremily.us
In Reply to: [gentoo-catalyst] [PATCH 6/6] Set mountmap["icecream"] from settings for now. by Brian Dolbec
1 On Sat, Dec 28, 2013 at 05:57:10PM -0800, Brian Dolbec wrote:
2 > mounts and mountmap are source paths.
3
4 “mountmap” is for source paths. “mounts” is for path-agnostic keys.
5
6 > - self.mounts.append("/var/cache/icecream")
7 > - self.mountmap["/var/cache/icecream"]="/var/cache/icecream"
8 > + self.mounts.append("icecream")
9 > + self.mountmap["icecream"] = self.settings["icecream"]
10
11 Looks good to me.
12
13 I haven't actually tested this series, but I did test two commits
14 further along in Brian's “pending” branch (8dfe5c7, Remove an extra
15 slash in the path, 2013-12-17). Everything worked well there. I'll
16 retest this series once we've worked the style kinks out of v1 ;).
17
18 Cheers,
19 Trevor
20
21 --
22 This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
23 For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-catalyst] [PATCH 6/6] Set mountmap["icecream"] from settings for now. "W. Trevor King" <wking@×××××××.us>