| 1 |
On Tue, 4 Mar 2014 22:27:44 -0800 |
| 2 |
"W. Trevor King" <wking@×××××××.us> wrote: |
| 3 |
|
| 4 |
> On Tue, Mar 04, 2014 at 09:07:03PM -0800, Brian Dolbec wrote: |
| 5 |
> > The unfortunate part is that a bunch of these changes will be |
| 6 |
> > replaced by other code later in the patch series. |
| 7 |
> |
| 8 |
> I don't think there are any critical fixes here. If it's easier to |
| 9 |
> drop this cleanup and just jump straight to the final version, that's |
| 10 |
> fine with me too. |
| 11 |
|
| 12 |
Yeah, they aren't critical, but I'd like to land them now anyway. |
| 13 |
|
| 14 |
> |
| 15 |
> > > On Sun, Mar 02, 2014 at 03:05:35PM -0800, Brian Dolbec wrote: |
| 16 |
> > > > Use: pjoin as a shorter alias to os.path.join() |
| 17 |
> > > |
| 18 |
> > > I think the saved characters are not worth the mental overhead of |
| 19 |
> > > an additional layer of indirection. |
| 20 |
> > > … |
| 21 |
> > |
| 22 |
|
| 23 |
I'll look at the pjoin use again. |
| 24 |
|
| 25 |
|
| 26 |
> > The autoresume stuff is later replaced with a self contained class. |
| 27 |
> > I was never sure if I should submit it, but it did fix a couple |
| 28 |
> > small issues. I can go either way with this one. |
| 29 |
> |
| 30 |
> Pulling it out into a class sounds good to me, but if it's easier to |
| 31 |
> land this first (after fixing the exists() typo) and submit the |
| 32 |
> class-based autoresume later, I'm fine with that. I wanted to point |
| 33 |
> out possible style changes, but none of that needs to be settled by |
| 34 |
> this particular patch. I think the removal of duplicate path |
| 35 |
> calculations is a step in the right direction. |
| 36 |
> |
| 37 |
> Cheers, |
| 38 |
> Trevor |
| 39 |
> |
| 40 |
|
| 41 |
-- |
| 42 |
Brian Dolbec <dolsen> |
Archives