Re: [gentoo-catalyst] [PATCH] support: delete unused code

[Brian Dolbec]

On Tue,  6 Oct 2015 17:45:07 -0400
Mike Frysinger <vapier@g.o> wrote:

> Using the vulture tool (and verifying a bit with `git grep`),
> delete various bits of code from this module that aren't used.
> ---
>  catalyst/support.py | 28 ----------------------------
>  1 file changed, 28 deletions(-)
>
> diff --git a/catalyst/support.py b/catalyst/support.py
> index f184ed7..62be63a 100644
> --- a/catalyst/support.py
> +++ b/catalyst/support.py
> @@ -1,7 +1,6 @@
>
>  import glob
>  import sys
> -import string  # pylint: disable=deprecated-module
>  import os
>  import types
>  import re
> @@ -11,35 +10,8 @@ from subprocess import Popen
>
>  from catalyst.defaults import verbosity, valid_config_file_values
>
> -selinux_capable = False
> -#userpriv_capable = (os.getuid() == 0)
> -#fakeroot_capable = False
> -
>  BASH_BINARY             = "/bin/bash"
>
> -# set it to 0 for the soft limit, 1 for the hard limit
> -DESIRED_RLIMIT = 0
> -try:
> -	import resource
> -
> max_fd_limit=resource.getrlimit(resource.RLIMIT_NOFILE)[DESIRED_RLIMIT]
> -except Exception:
> -	# hokay, no resource module.
> -	max_fd_limit=256
> -


Are you sure this is not needed?  Because I recall having to fix the
code because the API had changed, otherwise I couldn't get catalyst to
run.  But to be honest, catalyst is the only place I've seen this ever
used.  And so it is likely not needed.


> -# pids this process knows of.
> -spawned_pids = []
> -
> -
> -# a function to turn a string of non-printable characters
> -# into a string of hex characters
> -def hexify(s):
> -	hexStr = string.hexdigits
> -	r = ''
> -	for ch in s:
> -		i = ord(ch)
> -		r = r + hexStr[(i >> 4) & 0xF] + hexStr[i & 0xF]
> -	return r
> -
>
>  def read_from_clst(path):
>  	line = ''



-- 
Brian Dolbec <dolsen>