| 1 |
On Sat, Oct 17, 2020 at 12:00 PM Felix Bier |
| 2 |
<Felix.Bier@×××××××××××××.com> wrote: |
| 3 |
> |
| 4 |
> This commit fixes the following issues: |
| 5 |
> |
| 6 |
> * The PORTDIR_OVERLAY variable has been deprecated by Gentoo. |
| 7 |
> |
| 8 |
> With this commit, the variable is no longer written to the |
| 9 |
> generated make.conf. Instead, a config file |
| 10 |
> /etc/portage/repos.conf/<repo-name>.conf |
| 11 |
> is generated for each overlay. The repo name is read from the |
| 12 |
> overlay using the portage API. Internally, portage parses |
| 13 |
> metadata/layout.conf and profiles/repo_name to obtain the name. |
| 14 |
> |
| 15 |
> References: |
| 16 |
> https://wiki.gentoo.org/wiki//etc/portage/make.conf |
| 17 |
> https://wiki.gentoo.org/wiki//etc/portage/repos.conf |
| 18 |
> |
| 19 |
> * All overlays were copied into the same target directory. If the |
| 20 |
> same file name occurred in multiple overlays, the last overlay |
| 21 |
> would overwrite all previous files with this name. In particular, |
| 22 |
> only the metadata/layout.conf of the last overlay was retained, |
| 23 |
> so it was not possible to reference the other overlays e.g. via |
| 24 |
> the masters entry in the layout.conf or the portage-2 syntax |
| 25 |
> for specifying a parent profile from another overlay. Also, |
| 26 |
> this created problems when the overlays contained ebuilds |
| 27 |
> for the same package, but with differing versions, because |
| 28 |
> after copying, the target directory contained both versions of the |
| 29 |
> ebuild but only the manifest file of the last overlay. |
| 30 |
> |
| 31 |
> With this commit, each overlay is copied into a separate |
| 32 |
> sub-directory, e.g. /var/gentoo/repos/local/<repo-name>/. |
| 33 |
> This directory is referenced via the location entry in the |
| 34 |
> generated /etc/portage/repos.conf/<repo-name>.conf. |
| 35 |
> --- |
| 36 |
|
| 37 |
Hello, |
| 38 |
|
| 39 |
Thank you for the patches. I'm happy to see them. |
| 40 |
|
| 41 |
I cannot apply the patches however. This one in particular is badly |
| 42 |
line wrapped by your mail client. I tried fixing it up, but either |
| 43 |
failed or don't know what this is supposed to apply to. |
| 44 |
|
| 45 |
It looks like the intention is for this to apply to the |
| 46 |
catalyst-3.0-stable branch since it discusses copying overlays into a |
| 47 |
subdirectory, rather than any mention of squashfs snapshots. |
| 48 |
|
| 49 |
I really don't want new feature work on the catalyst-3.0-stable |
| 50 |
branch, for example. If that is the target, then please consider |
| 51 |
rebasing the work onto the master branch. |
| 52 |
|
| 53 |
Matt |
Archives