1 |
On Mon, 2013-01-07 at 18:53 -0800, Brian Dolbec wrote: |
2 |
> use the portdir setting rather than hard-coded path. |
3 |
> -- |
4 |
> Brian Dolbec <brian.dolbec@×××××.com> |
5 |
> |
6 |
> -- |
7 |
> Brian Dolbec <dolsen@g.o> |
8 |
|
9 |
|
10 |
Now that #3 has fianly made it to the list... |
11 |
|
12 |
What about some of the other paths in cleanables? Perhaps they too |
13 |
should be config'd and then use the the config value, rather than be |
14 |
hard-coded here. But not being involved in using catalyst, that is |
15 |
something I don't know. |
16 |
|
17 |
I see 'resolv.conf' and '/var/tmp/*' that probably should be config'd, |
18 |
what about 'root/*' |
19 |
|
20 |
By doing that. It would put all control back to the config, making it |
21 |
one place to edit for a simple path change. Easing maintenance for the |
22 |
future. |
23 |
|
24 |
|
25 |
> |
26 |
From 773edaaf1db072c5b15b3680413d1fb9e5841593 Mon Sep 17 00:00:00 2001 |
27 |
From: Brian Dolbec <dolsen@g.o> |
28 |
Date: Wed, 19 Dec 2012 18:10:15 -0800 |
29 |
Subject: [PATCH] use the portdir setting rather than hard-coded path |
30 |
|
31 |
--- |
32 |
modules/tinderbox_target.py | 4 ++-- |
33 |
1 file changed, 2 insertions(+), 2 deletions(-) |
34 |
|
35 |
diff --git a/modules/tinderbox_target.py b/modules/tinderbox_target.py |
36 |
index 46fe082..d6d3ea3 100644 |
37 |
--- a/modules/tinderbox_target.py |
38 |
+++ b/modules/tinderbox_target.py |
39 |
@@ -29,8 +29,8 @@ class tinderbox_target(generic_stage_target): |
40 |
raise CatalystError,"Tinderbox aborting due to |
41 |
error." |
42 |
|
43 |
def set_cleanables(self): |
44 |
- |
45 |
self.settings["cleanables"]=["/etc/resolv.conf","/var/tmp/*","/root/*",\ |
46 |
- "/usr/portage"] |
47 |
+ |
48 |
self.settings["cleanables"]=["/etc/resolv.conf","/var/tmp/*","/root/*", |
49 |
+ self.settings['portdir']] |
50 |
|
51 |
def set_action_sequence(self): |
52 |
#Default action sequence for run method |
53 |
-- |
54 |
1.8.0 |
55 |
|
56 |
|
57 |
-- |
58 |
Brian Dolbec <dolsen@g.o> |