Gentoo Archives: gentoo-catalyst

From: Mike Frysinger <vapier@g.o>
To: gentoo-catalyst@l.g.o
Subject: [gentoo-catalyst] [PATCH 12/13] targets: fix bad set_build_kernel_vars call
Date: Tue, 06 Oct 2015 15:06:18
Message-Id: 1444143929-26705-12-git-send-email-vapier@gentoo.org
In Reply to: [gentoo-catalyst] [PATCH 01/13] lint: fix duplicate fcntl import by Mike Frysinger
1 These modules were calling set_build_kernel_vars with an argument that
2 the func didn't accept. Plus, it's redundant as the super class init
3 (which these guys call) already handles the call. So delete it.
4 ---
5 catalyst/targets/embedded.py | 1 -
6 catalyst/targets/netboot.py | 1 -
7 catalyst/targets/netboot2.py | 1 -
8 3 files changed, 3 deletions(-)
9
10 diff --git a/catalyst/targets/embedded.py b/catalyst/targets/embedded.py
11 index 3309278..6044e17 100644
12 --- a/catalyst/targets/embedded.py
13 +++ b/catalyst/targets/embedded.py
14 @@ -28,7 +28,6 @@ class embedded(StageBase):
15 self.valid_values.append("embedded/fs-ops")
16
17 StageBase.__init__(self,spec,addlargs)
18 - self.set_build_kernel_vars(addlargs)
19
20 def set_action_sequence(self):
21 self.settings["action_sequence"]=["dir_setup","unpack","unpack_snapshot",\
22 diff --git a/catalyst/targets/netboot.py b/catalyst/targets/netboot.py
23 index b0e322c..46ec4eb 100644
24 --- a/catalyst/targets/netboot.py
25 +++ b/catalyst/targets/netboot.py
26 @@ -44,7 +44,6 @@ class netboot(StageBase):
27 raise CatalystError("configuration error in netboot/packages.")
28
29 StageBase.__init__(self,spec,addlargs)
30 - self.set_build_kernel_vars(addlargs)
31 if "netboot/busybox_config" in addlargs:
32 file_locate(self.settings, ["netboot/busybox_config"])
33
34 diff --git a/catalyst/targets/netboot2.py b/catalyst/targets/netboot2.py
35 index f2d039c..5508367 100644
36 --- a/catalyst/targets/netboot2.py
37 +++ b/catalyst/targets/netboot2.py
38 @@ -46,7 +46,6 @@ class netboot2(StageBase):
39 raise CatalystError("configuration error in netboot2/packages.")
40
41 StageBase.__init__(self,spec,addlargs)
42 - self.set_build_kernel_vars()
43 self.settings["merge_path"]=normpath("/tmp/image/")
44
45 def set_target_path(self):
46 --
47 2.5.2