| 1 |
On Thu, 14 May 2020 23:37:30 -0700 |
| 2 |
Matt Turner <mattst88@g.o> wrote: |
| 3 |
|
| 4 |
> Even though squashfs is not writeable, it must be mounted with -o ro |
| 5 |
> in order to be mounted multiple times. This allows, for example, the |
| 6 |
> same snapshot to be mounted simultaneously in multiple catalyst |
| 7 |
> chroots. |
| 8 |
> |
| 9 |
> Signed-off-by: Matt Turner <mattst88@g.o> |
| 10 |
> --- |
| 11 |
> catalyst/base/stagebase.py | 4 +++- |
| 12 |
> 1 file changed, 3 insertions(+), 1 deletion(-) |
| 13 |
> |
| 14 |
> diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py |
| 15 |
> index 55d1032d..651bf4e4 100644 |
| 16 |
> --- a/catalyst/base/stagebase.py |
| 17 |
> +++ b/catalyst/base/stagebase.py |
| 18 |
> @@ -868,7 +868,9 @@ class StageBase(TargetBase, ClearBase, GenBase): |
| 19 |
> mount += ['-t', 'tmpfs', '-o', 'noexec,nosuid,nodev'] |
| 20 |
> else: |
| 21 |
> source_path = Path(self.mount[x]['source']) |
| 22 |
> - if source_path.suffix != '.sqfs': |
| 23 |
> + if source_path.suffix == '.sqfs': |
| 24 |
> + mount += ['-o', 'ro'] |
| 25 |
> + else: |
| 26 |
> mount.append('--bind') |
| 27 |
> |
| 28 |
> # We may need to create the source of the bind |
| 29 |
> mount. E.g., in the |
| 30 |
|
| 31 |
Yes to patch #2 and #3 |
| 32 |
|
| 33 |
Please make a header email for multiple commits series, Is easier to |
| 34 |
approve all with one email ;) |
| 35 |
|
| 36 |
I don't know why but I'm getting yours out of numerical order in |
| 37 |
claws-mail... |
Archives