Gentoo Archives: gentoo-catalyst

From: Daniel Cordero <gentoo.catalyst@××××.ws>
To: gentoo-catalyst@l.g.o
Subject: [gentoo-catalyst] [PATCH 3/5] embedded/rm: use destpath to clean mergeroot
Date: Thu, 21 May 2020 17:34:44
Message-Id: 20200521173248.2297765-3-gentoo.catalyst@xxoo.ws
In Reply to: [gentoo-catalyst] [PATCH 1/5] embedded: remove actions that are broken by default by Daniel Cordero
1 From: Daniel Cordero <catalyst@××××.io>
2
3 When using remove() with a capture subpath (e.g. the embedded target), specifying
4 files in rm removes the files from the seed stage, not the captured stage.
5
6 Use destpath as a base for removals. When not using a subpath, destpath
7 equals chroot_path.
8
9 Also unhardcode log prefix to match the target.
10 ---
11 catalyst/base/stagebase.py | 4 ++--
12 1 file changed, 2 insertions(+), 2 deletions(-)
13
14 diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
15 index 3e8f074e..ed9bb697 100644
16 --- a/catalyst/base/stagebase.py
17 +++ b/catalyst/base/stagebase.py
18 @@ -1171,8 +1171,8 @@ class StageBase(TargetBase, ClearBase, GenBase):
19 for x in self.settings[self.settings["spec_prefix"] + "/rm"]:
20 # We're going to shell out for all these cleaning
21 # operations, so we get easy glob handling.
22 - log.notice('livecd: removing %s', x)
23 - clear_path(self.settings["chroot_path"] + x)
24 + log.notice('%s: removing %s', self.settings["spec_prefix"], x)
25 + clear_path(self.settings["destpath"] + x)
26 try:
27 if os.path.exists(self.settings["controller_file"]):
28 cmd([self.settings['controller_file'], 'clean'],
29 --
30 2.26.2

Replies