| 1 |
What's the bug? More details in the commit message would be good. |
| 2 |
|
| 3 |
On Tue, Dec 17, 2013 at 05:12:11PM -0800, Brian Dolbec wrote: |
| 4 |
> - local destdir=".${subdir}/tmp" |
| 5 |
> + local destdir="${subdir}/tmp" |
| 6 |
> … |
| 7 |
> copy_to_chroot ${1} ${destdir} |
| 8 |
> @@ -33,7 +33,7 @@ exec_in_chroot(){ |
| 9 |
> chmod +x ${chroot_path}/${destdir}/${file_name} |
| 10 |
|
| 11 |
If we're requiring ${subdir} (and thus ${destdit}) to be an absolute |
| 12 |
chroot path, you may want to fix this too. |
| 13 |
|
| 14 |
> echo "Running ${file_name} in chroot ${chroot_path}" |
| 15 |
> - ${clst_CHROOT} ${chroot_path} ${destdir}/${file_name} || exit 1 |
| 16 |
> + ${clst_CHROOT} ${chroot_path} .${destdir}/${file_name} || exit 1 |
| 17 |
|
| 18 |
Do we need the leading dot here? Can we store: |
| 19 |
|
| 20 |
file_path="${chroot_path}/${destdir}/${file_name}" |
| 21 |
|
| 22 |
and use that for both the chmod and clst_CHROOT calls? |
| 23 |
|
| 24 |
Cheers, |
| 25 |
Trevor |
| 26 |
|
| 27 |
-- |
| 28 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
| 29 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |
Archives