1 |
On Fri, Oct 23, 2020 at 10:01 AM Daniel Cordero <gentoo.catalyst@××××.ws> wrote: |
2 |
> |
3 |
> On Fri, Oct 23, 2020 at 09:25:29AM -0700, Matt Turner wrote: |
4 |
> > On Fri, Oct 23, 2020 at 2:19 AM Daniel Cordero <gentoo.catalyst@××××.ws> wrote: |
5 |
> > > |
6 |
> > > From: Daniel Cordero <catalyst@××××.io> |
7 |
> > > |
8 |
> > > Previous syslinux based CDs had this information. |
9 |
> > > Necessary for direct kernel booting with virt-install --location. |
10 |
> > > |
11 |
> > > Fixes: 0a27a7a39a "targets: Use GRUB for BIOS boot" |
12 |
> > > |
13 |
> > > Signed-off-by: Daniel Cordero <catalyst@××××.io> |
14 |
> > > --- |
15 |
> > > targets/support/create-iso.sh | 1 + |
16 |
> > > 1 file changed, 1 insertion(+) |
17 |
> > > |
18 |
> > > diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh |
19 |
> > > index 9b1c7185..b11b046f 100755 |
20 |
> > > --- a/targets/support/create-iso.sh |
21 |
> > > +++ b/targets/support/create-iso.sh |
22 |
> > > @@ -192,6 +192,7 @@ case ${clst_hostarch} in |
23 |
> > > isoroot_checksum |
24 |
> > > |
25 |
> > > case ${clst_hostarch} in |
26 |
> > > + amd64|x86) extra_opts="-joliet" ;; |
27 |
> > |
28 |
> > Is there any reason to limit this to amd64/x86? |
29 |
> > |
30 |
> |
31 |
> My concern is that the other arches may not have had this information on |
32 |
> their ISOs. I do not know if those arches might not like it. |
33 |
|
34 |
Oh, I see: this flag is passed through grub-mkrescue to mkisofs. I |
35 |
guess this is an alias for the -J flag to mkisofs? Strange that I |
36 |
don't see it documented in either mkisofs(8) or grub-mkrescue(1). It |
37 |
looks like we're passing -J to mkisofs/xorriso on alpha and hppa, so |
38 |
my feeling is that we should just use it on all platforms. I'm happy |
39 |
to adjust the patch when I commit it. |