[gentoo-catalyst] Re: [PATCH] Make the use of preserved_libs optional by setting the options variable.

[W. Trevor King]

On Sun, Mar 31, 2013 at 02:31:45AM +0000, Jorge Manuel B. S. Vicetto (jmbsvicetto) wrote:
> diff --git a/catalyst b/catalyst
> index 9f8dd30..f885dd4 100755
> --- a/catalyst
> +++ b/catalyst
> @@ -147,6 +147,9 @@ def parse_config(myconfig):
>  	if "pkgcache" in string.split(conf_values["options"]):
>  		print "Package cache support enabled."
>  		conf_values["PKGCACHE"]="1"
> +	if "preserve_libs" in string.split(conf_values["options"]);
> +		print "Preserving libs during unmerge."
> +		conf_values["PRESERVE_LIBS"]="1"
>
>  	if "purge" in string.split(conf_values["options"]):
>  		print "Purge support enabled."
> diff --git a/files/catalyst.conf b/files/catalyst.conf
> index f88f105..2983acc 100644
> --- a/files/catalyst.conf
> +++ b/files/catalyst.conf
> @@ -59,6 +59,8 @@ hash_function="crc32"
>  #	build stops in livecd-stage2)
>  # pkgcache = keeps a tbz2 of every built package (useful if your build stops
>  #	prematurely)
> +# preserve_libs = enables portage to preserve used libs when unmerging packages
> +#   (used on installcd-stage2 and stage4 targets)
>  # seedcache = use the build output of a previous target if it exists to speed up
>  #	the copy
>  # snapcache = cache the snapshot so that it can be bind-mounted into the chroot.

Your whitespace looks inconsistent.  You're missing a blank line
before `if "preserve_libs" …`, and you've got some extra space in the
wrapped catalyst.conf comment.  It looks like the existing
catalyst.conf comments aren't particularly consistent, but the two
existing choices seem to be `#<TAB><COMMENT>` and
`#<SPACE><TAB><COMMENT>`.

Other than that, I like this patch.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy