Gentoo Archives: gentoo-catalyst

From: Brian Dolbec <dolsen@g.o>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] [PATCH 8/9] lint: convert type/types to isinstance
Date: Wed, 28 Oct 2015 14:56:52
Message-Id: 20151028075556.7e29cae0.dolsen@gentoo.org
In Reply to: [gentoo-catalyst] [PATCH 8/9] lint: convert type/types to isinstance by Mike Frysinger
1 On Mon, 12 Oct 2015 00:36:01 -0400
2 Mike Frysinger <vapier@g.o> wrote:
3
4 > pylint complains about using (type(...) == types.xxx) checks as it
5 > prefers isinstance(..., xxx) instead. Convert the code base to it.
6 > ---
7 > .pylintrc | 3 +--
8 > catalyst/base/stagebase.py | 57
9 > +++++++++++++++++----------------------
10 > catalyst/support.py | 3 +--
11 > catalyst/targets/grp.py | 5 ++--
12 > catalyst/targets/livecd_stage1.py | 5 ++--
13 > catalyst/targets/netboot.py | 9 +++----
14 > catalyst/targets/netboot2.py | 11 ++++---- 7 files changed, 39
15 > insertions(+), 54 deletions(-)
16 >
17 >
18
19 looks good.
20
21 Thanks, yet another task done that has been bugging me for quite a
22 while.
23
24 --
25 Brian Dolbec <dolsen>