Gentoo Archives: gentoo-catalyst

From: Brian Dolbec <dolsen@g.o>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] [PATCH 4/8] targets: Remove unused source filesystem-functions.sh
Date: Sat, 02 May 2020 23:51:22
Message-Id: 20200502165107.7faaa71f@storm
In Reply to: Re: [gentoo-catalyst] [PATCH 4/8] targets: Remove unused source filesystem-functions.sh by Matt Turner
1 On Sat, 2 May 2020 16:20:31 -0700
2 Matt Turner <mattst88@g.o> wrote:
3
4 > On Sat, May 2, 2020 at 4:06 PM Brian Dolbec <dolsen@g.o> wrote:
5 > >
6 > > On Fri, 1 May 2020 18:40:32 -0700
7 > > Matt Turner <mattst88@g.o> wrote:
8 > >
9 > > > Signed-off-by: Matt Turner <mattst88@g.o>
10 > > > ---
11 > >
12 > > This one makes more sense if you had mentioned the previous commit
13 > > that inlined it.
14 > >
15 > > Perhaps even merge the 2 commits into one
16 >
17 > This commit is fully independent of the previous. They do not touch
18 > any of the same files.
19 >
20
21 yeah, my bad... my brain convieniently left out the word "source" from
22 its understanding of the commit message. Now if it had said "Remove
23 unused import..." my python would have kicked in, not confused the
24 meaning...