1 |
Previous submissions for this patch: [1,2]. It's already been acked |
2 |
by Matt [3] and me [4]. I acked it again on IRC on 2014-06-15: |
3 |
|
4 |
08:02 < wking> dol-sen: I don't see how c718315 (Remove unused |
5 |
urllib import, 2013-02-11) could possibly break anything ;). |
6 |
08:02 < wking> But I'm going through stages one through three anyway |
7 |
just to be sure ;) |
8 |
08:03 < wking> Are you going to mail these to the list, or are you |
9 |
planning on polishing them first, and then submitting them to the |
10 |
list? |
11 |
08:03 <@dol-sen> they need some work |
12 |
… |
13 |
18:16 < wking> dol-sen: c718315 is now 135 of 263 in my stage 3, so |
14 |
I think it's good to merge to master (after floating on the list, |
15 |
if that's still Catalyst policy). |
16 |
21:50 <@jmbsvicetto> dol-sen / wking: please keep reviewing those |
17 |
patches with any help in the catalyst ml. I'll likely be tied for |
18 |
a while and won't have time to go over them, but I trust your |
19 |
judgement |
20 |
21:50 <@jmbsvicetto> dol-sen: feel free to commit them whenever |
21 |
you're happy. |
22 |
21:51 <@jmbsvicetto> Zero_Chaos: ^^ Please try to review them when |
23 |
you can to ensure you don't get any surprises |
24 |
21:52 <@jmbsvicetto> dol-sen: I can try to setup automated builds |
25 |
with the rewrite branch on my server so we can get automated |
26 |
feedback about it |
27 |
|
28 |
So after three submissions and three acks (one on this exact c718315 |
29 |
commit), I think we can safely land this one ;). |
30 |
|
31 |
Cheers, |
32 |
Trevor |
33 |
|
34 |
[1]: http://article.gmane.org/gmane.linux.gentoo.catalyst/2158 |
35 |
[2]: http://article.gmane.org/gmane.linux.gentoo.catalyst/2364 |
36 |
[3]: http://thread.gmane.org/gmane.linux.gentoo.catalyst/2361/focus=2378 |
37 |
[4]: http://thread.gmane.org/gmane.linux.gentoo.catalyst/2361/focus=2425 |
38 |
|
39 |
-- |
40 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
41 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |