Gentoo Archives: gentoo-catalyst

From: Dylan Baker <baker.dylan.c@×××××.com>
To: gentoo-catalyst@l.g.o
Cc: Dylan Baker <baker.dylan.c@×××××.com>
Subject: [gentoo-catalyst] [Patch v2 3/4] catalyst: split combined import
Date: Sun, 13 Oct 2013 09:07:46
Message-Id: 1381655258-6084-3-git-send-email-baker.dylan.c@gmail.com
In Reply to: [gentoo-catalyst] [Patch v2 1/4] catalyst: Specify python2 rather than the generic python by Dylan Baker
1 Combining multiple modules into a single import is discouraged in
2 python's PEP8 style guide:
3
4 """
5 Imports should usually be on separate lines, e.g.:
6
7 Yes: import os
8 import sys
9
10 No: import sys, os
11 """
12 ---
13 catalyst | 6 +++++-
14 1 file changed, 5 insertions(+), 1 deletion(-)
15
16 diff --git a/catalyst b/catalyst
17 index 2378a87..36bd709 100755
18 --- a/catalyst
19 +++ b/catalyst
20 @@ -7,7 +7,11 @@
21 # Chris Gianelloni <wolf31o2@××××××××.org>
22 # $Id$
23
24 -import os, sys, imp, string, getopt
25 +import os
26 +import sys
27 +import imp
28 +import string
29 +import getopt
30 import pdb
31 import os.path
32
33 --
34 1.8.1.5