Gentoo Archives: gentoo-commits

From: "Michał Górny" <mgorny@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/
Date: Wed, 08 Mar 2017 07:36:15
Message-Id: 1488958533.8e1bff5146ca3f6305ce7349b963c8fa19bc9b63.mgorny@gentoo
1 commit: 8e1bff5146ca3f6305ce7349b963c8fa19bc9b63
2 Author: Michał Górny <mgorny <AT> gentoo <DOT> org>
3 AuthorDate: Thu Feb 23 18:20:01 2017 +0000
4 Commit: Michał Górny <mgorny <AT> gentoo <DOT> org>
5 CommitDate: Wed Mar 8 07:35:33 2017 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e1bff51
7
8 ruby-fakegem.eclass: Remove completely unnecessary 'eval ls'
9
10 Filename expansion is performed when the variable is referenced unquoted
11 already. There is really no need to call 'ls' on top of that, and even
12 less reason to wrap it all in 'eval'.
13
14 eclass/ruby-fakegem.eclass | 5 ++---
15 1 file changed, 2 insertions(+), 3 deletions(-)
16
17 diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass
18 index 69ab29f7fb8..b1795fa46c9 100644
19 --- a/eclass/ruby-fakegem.eclass
20 +++ b/eclass/ruby-fakegem.eclass
21 @@ -521,9 +521,8 @@ all_fakegem_install() {
22
23 if [[ -d "${bindir}" ]]; then
24 pushd "${bindir}" &>/dev/null || die
25 - local binaries=$(eval ls ${RUBY_FAKEGEM_BINWRAP})
26 - for binary in $binaries; do
27 - ruby_fakegem_binwrapper $binary
28 + for binary in ${RUBY_FAKEGEM_BINWRAP}; do
29 + ruby_fakegem_binwrapper "${binary}"
30 done
31 popd &>/dev/null || die
32 fi