Gentoo Archives: gentoo-commits

From: Fabian Groffen <grobian@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage-utils:master commit in: /
Date: Thu, 26 May 2022 14:53:50
Message-Id: 1653576616.fd7528a6b55e824872bfe79415d2ddae5948ca5e.grobian@gentoo
1 commit: fd7528a6b55e824872bfe79415d2ddae5948ca5e
2 Author: Fabian Groffen <grobian <AT> gentoo <DOT> org>
3 AuthorDate: Thu May 26 14:50:16 2022 +0000
4 Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org>
5 CommitDate: Thu May 26 14:50:16 2022 +0000
6 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=fd7528a6
7
8 qdepends: plug Coverity CID 269971 (resource leak)
9
10 Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>
11
12 qdepends.c | 8 +++++---
13 1 file changed, 5 insertions(+), 3 deletions(-)
14
15 diff --git a/qdepends.c b/qdepends.c
16 index bd7c379..f222011 100644
17 --- a/qdepends.c
18 +++ b/qdepends.c
19 @@ -199,11 +199,13 @@ qdepends_results_cb(tree_pkg_ctx *pkg_ctx, void *priv)
20 tree_pkg_meta_get(vpkg, BDEPEND);
21 if (depstr != NULL) {
22 dep_node *dep_vdb = dep_grow_tree(depstr);
23 - if (dep_vdb != NULL)
24 + if (dep_vdb != NULL) {
25 dep_flatten_tree(dep_vdb, state->deps);
26 - else
27 + dep_burn_tree(dep_vdb);
28 + } else {
29 warn("failed to parse VDB depstring from %s\n",
30 - atom_to_string(datom));
31 + atom_to_string(datom));
32 + }
33 }
34 tree_close_pkg(vpkg);
35 }