| 1 |
commit: 84559890f05ae01e3360922c05cafca2fa8d23ea |
| 2 |
Author: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Sun Jan 19 18:06:37 2020 +0000 |
| 4 |
Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Sun Jan 19 18:06:37 2020 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=84559890 |
| 7 |
|
| 8 |
qdepends: fix Coverity 206553 Logically dead code |
| 9 |
|
| 10 |
Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org> |
| 11 |
|
| 12 |
qdepends.c | 5 ++--- |
| 13 |
1 file changed, 2 insertions(+), 3 deletions(-) |
| 14 |
|
| 15 |
diff --git a/qdepends.c b/qdepends.c |
| 16 |
index 6f580a9..865605e 100644 |
| 17 |
--- a/qdepends.c |
| 18 |
+++ b/qdepends.c |
| 19 |
@@ -162,7 +162,7 @@ qdepends_results_cb(tree_pkg_ctx *pkg_ctx, void *priv) |
| 20 |
depstr = i == 1<<0 ? tree_pkg_meta_get(pkg_ctx, DEPEND) : |
| 21 |
i == 1<<1 ? tree_pkg_meta_get(pkg_ctx, RDEPEND) : |
| 22 |
i == 1<<2 ? tree_pkg_meta_get(pkg_ctx, PDEPEND) : |
| 23 |
- i == 1<<3 ? tree_pkg_meta_get(pkg_ctx, BDEPEND) : NULL; |
| 24 |
+ tree_pkg_meta_get(pkg_ctx, BDEPEND); |
| 25 |
if (depstr == NULL) |
| 26 |
continue; |
| 27 |
dep_tree = dep_grow_tree(depstr); |
| 28 |
@@ -180,8 +180,7 @@ qdepends_results_cb(tree_pkg_ctx *pkg_ctx, void *priv) |
| 29 |
depstr = i == 1<<0 ? tree_pkg_meta_get(vpkg, DEPEND) : |
| 30 |
i == 1<<1 ? tree_pkg_meta_get(vpkg, RDEPEND) : |
| 31 |
i == 1<<2 ? tree_pkg_meta_get(vpkg, PDEPEND) : |
| 32 |
- i == 1<<3 ? tree_pkg_meta_get(vpkg, BDEPEND) : |
| 33 |
- NULL; |
| 34 |
+ tree_pkg_meta_get(vpkg, BDEPEND); |
| 35 |
if (depstr != NULL) { |
| 36 |
dep_node *dep_vdb = dep_grow_tree(depstr); |
| 37 |
if (dep_vdb != NULL) |
Archives