Gentoo Archives: gentoo-commits

From: Sergei Trofimovich <slyfox@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/crossdev:master commit in: /
Date: Sun, 19 Nov 2017 23:03:27
Message-Id: 1511132415.da9b5185640ac15d930624e1d52621c8a3da87f2.slyfox@gentoo
1 commit: da9b5185640ac15d930624e1d52621c8a3da87f2
2 Author: Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
3 AuthorDate: Sun Nov 19 22:58:48 2017 +0000
4 Commit: Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
5 CommitDate: Sun Nov 19 23:00:15 2017 +0000
6 URL: https://gitweb.gentoo.org/proj/crossdev.git/commit/?id=da9b5185
7
8 crossdev: remove support for undocumented -b -d -p -v -q -pv -vp options, bug #638182
9
10 In bug #638182 Maciej tried to use crossdev as:
11 crossdev -t x86_64-w64-mingw32 -b 2.28.1
12 which attempted to build configs for '2.28.1' target.
13
14 crossdev silently passed '-b' to emerge and treated
15 next argument as target option.
16
17 This change removes all undocumented options.
18 Use '-P <option>' instead.
19
20 That way typo is reported correctly as:
21 * UNKNOWN OPTION: '-b'
22
23 Bug: https://bugs.gentoo.org/638182
24 Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org>
25
26 crossdev | 2 --
27 1 file changed, 2 deletions(-)
28
29 diff --git a/crossdev b/crossdev
30 index 0eaa721..3a3fdf5 100755
31 --- a/crossdev
32 +++ b/crossdev
33 @@ -652,8 +652,6 @@ while [[ $# -gt 0 ]] ; do
34 --show-fail-log) SHOW_FAIL_LOG="yes";;
35 --show-repo-cfg) show_repo_cfg "$2";;
36 -P|--portage) UOPTS="${UOPTS} $2"; shift;;
37 - -b|-d|-p|-v|-q) UOPTS="${UOPTS} $1";;
38 - -pv|-vp) UOPTS="${UOPTS} -p -v";;
39 -h|--help) usage;;
40 -*) eerror "UNKNOWN OPTION: '$1'" ; usage 1;;
41 *) parse_target $1;;