1 |
commit: 70cf788ec5d4f493c099c34c28fb5fdabcd91eac |
2 |
Author: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
3 |
AuthorDate: Mon Jan 20 19:37:33 2020 +0000 |
4 |
Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
5 |
CommitDate: Mon Jan 20 19:37:33 2020 +0000 |
6 |
URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=70cf788e |
7 |
|
8 |
qtegrity: fix Coverity 185976 Dereference before null check |
9 |
|
10 |
Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org> |
11 |
|
12 |
qtegrity.c | 5 ++--- |
13 |
1 file changed, 2 insertions(+), 3 deletions(-) |
14 |
|
15 |
diff --git a/qtegrity.c b/qtegrity.c |
16 |
index 0d23a7f..c2fc221 100644 |
17 |
--- a/qtegrity.c |
18 |
+++ b/qtegrity.c |
19 |
@@ -306,14 +306,13 @@ int qtegrity_main(int argc, char **argv) |
20 |
get_digest_from_line(buffered_line, recorded_digest, |
21 |
recorded_digest_size, 50); |
22 |
|
23 |
- if (recorded_fname == NULL || recorded_digest == NULL) { |
24 |
+ if (recorded_fname == NULL || *recorded_digest == '\0') { |
25 |
printf("Empty recorded filename: %s\n", line); |
26 |
|
27 |
if (recorded_fname != NULL) |
28 |
free(recorded_fname); |
29 |
|
30 |
- if (recorded_digest != NULL) |
31 |
- free(recorded_digest); |
32 |
+ free(recorded_digest); |
33 |
|
34 |
continue; |
35 |
} |