Gentoo Archives: gentoo-commits

From: Marek Szuba <marecki@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: x11-plugins/pidgin-gnome-keyring/, x11-plugins/pidgin-gnome-keyring/files/
Date: Tue, 20 Apr 2021 09:42:39
Message-Id: 1618911746.6d117a5f516289df25c66703b1a9620826078f0a.marecki@gentoo
1 commit: 6d117a5f516289df25c66703b1a9620826078f0a
2 Author: Marek Szuba <marecki <AT> gentoo <DOT> org>
3 AuthorDate: Tue Apr 20 09:33:00 2021 +0000
4 Commit: Marek Szuba <marecki <AT> gentoo <DOT> org>
5 CommitDate: Tue Apr 20 09:42:26 2021 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d117a5f
7
8 x11-plugins/pidgin-gnome-keyring: fix pkgconfig calls in the Makefile
9
10 For some reason upstream has opted to this as `pkg-config foo`, which
11 as reported in Bug #784323 does not always (I still cannot reproduce it
12 on my end) work as it should. Do it the proper Make way, i.e. with
13 $(shell pkg-config foo).
14
15 While at it, bump the package to EAPI 7.
16
17 Closes: https://bugs.gentoo.org/784323
18 Signed-off-by: Marek Szuba <marecki <AT> gentoo.org>
19
20 .../pidgin-gnome-keyring-2.0-pkgconfig_dirs.patch | 32 ++++++++++++++++++++++
21 .../pidgin-gnome-keyring-2.0-r1.ebuild | 29 ++++++++++++++++++++
22 2 files changed, 61 insertions(+)
23
24 diff --git a/x11-plugins/pidgin-gnome-keyring/files/pidgin-gnome-keyring-2.0-pkgconfig_dirs.patch b/x11-plugins/pidgin-gnome-keyring/files/pidgin-gnome-keyring-2.0-pkgconfig_dirs.patch
25 new file mode 100644
26 index 00000000000..4f33cee6531
27 --- /dev/null
28 +++ b/x11-plugins/pidgin-gnome-keyring/files/pidgin-gnome-keyring-2.0-pkgconfig_dirs.patch
29 @@ -0,0 +1,32 @@
30 +--- a/Makefile
31 ++++ b/Makefile
32 +@@ -1,10 +1,11 @@
33 + TARGET = gnome-keyring
34 +
35 +-SECRETFLAGS = `pkg-config --libs --cflags libsecret-1`
36 +-PURPLEFLAGS = `pkg-config --cflags purple`
37 +-VERSION = $(shell cat VERSION)
38 ++SECRETFLAGS := $(shell pkg-config --libs --cflags libsecret-1)
39 ++PURPLEFLAGS := $(shell pkg-config --cflags purple)
40 ++PLUGINDIR := $(shell pkg-config --variable=plugindir purple)
41 ++VERSION := $(shell cat VERSION)
42 + ifeq ($(strip $(VERSION)),)
43 +- VERSION = `git describe --tags`
44 ++ VERSION := $(shell git describe --tags)
45 + endif
46 +
47 + all: ${TARGET}.so
48 +@@ -15,11 +16,10 @@
49 +
50 + ${TARGET}.so: ${TARGET}.c
51 +
52 +- ${CC} ${CFLAGS} ${LDFLAGS} -Wall -I. -g -O2 ${TARGET}.c -o ${TARGET}.so -shared -fPIC -DPIC -ggdb ${PURPLEFLAGS} ${SECRETFLAGS} -DVERSION=\"${VERSION}\"
53 ++ ${CC} ${CFLAGS} ${LDFLAGS} -Wall -I. ${TARGET}.c -o ${TARGET}.so -shared -fPIC -DPIC ${PURPLEFLAGS} ${SECRETFLAGS} -DVERSION=\"${VERSION}\"
54 +
55 + install: ${TARGET}.so
56 +- mkdir -p ${DESTDIR}/usr/lib/purple-2/
57 +- cp ${TARGET}.so ${DESTDIR}/usr/lib/purple-2/
58 ++ install -D ${TARGET}.so ${DESTDIR}/$(PLUGINDIR)/${TARGET}.so
59 +
60 + install_local: ${TARGET}.so
61 + mkdir -p ~/.purple/plugins
62
63 diff --git a/x11-plugins/pidgin-gnome-keyring/pidgin-gnome-keyring-2.0-r1.ebuild b/x11-plugins/pidgin-gnome-keyring/pidgin-gnome-keyring-2.0-r1.ebuild
64 new file mode 100644
65 index 00000000000..0bbf1d34fc2
66 --- /dev/null
67 +++ b/x11-plugins/pidgin-gnome-keyring/pidgin-gnome-keyring-2.0-r1.ebuild
68 @@ -0,0 +1,29 @@
69 +# Copyright 1999-2021 Gentoo Authors
70 +# Distributed under the terms of the GNU General Public License v2
71 +
72 +EAPI=7
73 +
74 +DESCRIPTION="Integrates Pidgin (and libpurple) with the system keyring"
75 +HOMEPAGE="https://github.com/aebrahim/pidgin-gnome-keyring"
76 +SRC_URI="https://github.com/aebrahim/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"
77 +
78 +LICENSE="GPL-2+"
79 +SLOT="0"
80 +KEYWORDS="~amd64 ~x86"
81 +
82 +RDEPEND="app-crypt/libsecret
83 + net-im/pidgin"
84 +DEPEND="${RDEPEND}"
85 +BDEPEND="virtual/pkgconfig"
86 +
87 +PATCHES=(
88 + "${FILESDIR}/${P}-pkgconfig_dirs.patch"
89 +)
90 +
91 +src_prepare() {
92 + default
93 +
94 + # This file is used by the upstream Makefile yet as of 2.0 is still missing
95 + # from release tarballs.
96 + echo "${PV}" > VERSION || die "Failed to recreate version file"
97 +}