| 1 |
commit: d99cc22a91b06d53cc3ef3ff159f25c71d62e750 |
| 2 |
Author: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Wed Jan 22 19:49:59 2020 +0000 |
| 4 |
Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Wed Jan 22 19:49:59 2020 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=d99cc22a |
| 7 |
|
| 8 |
qpkg: fix Coverity 125923 Resource leak |
| 9 |
|
| 10 |
Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org> |
| 11 |
|
| 12 |
qpkg.c | 3 +++ |
| 13 |
1 file changed, 3 insertions(+) |
| 14 |
|
| 15 |
diff --git a/qpkg.c b/qpkg.c |
| 16 |
index 7835cd7..948d564 100644 |
| 17 |
--- a/qpkg.c |
| 18 |
+++ b/qpkg.c |
| 19 |
@@ -198,18 +198,21 @@ qpkg_make(depend_atom *atom) |
| 20 |
|
| 21 |
snprintf(tmpdir, sizeof(tmpdir), "%s/qpkg.XXXXXX", qpkg_bindir); |
| 22 |
if ((i = mkstemp(tmpdir)) == -1) { |
| 23 |
+ fclose(fp); |
| 24 |
free(buf); |
| 25 |
return -2; |
| 26 |
} |
| 27 |
close(i); |
| 28 |
unlink(tmpdir); |
| 29 |
if (mkdir(tmpdir, 0750)) { |
| 30 |
+ fclose(fp); |
| 31 |
free(buf); |
| 32 |
return -3; |
| 33 |
} |
| 34 |
|
| 35 |
snprintf(filelist, sizeof(filelist), "%s/filelist", tmpdir); |
| 36 |
if ((out = fopen(filelist, "w")) == NULL) { |
| 37 |
+ fclose(fp); |
| 38 |
free(buf); |
| 39 |
return -4; |
| 40 |
} |
Archives