[gentoo-commits] gentoo-x86 commit in eclass: elisp-common.eclass elisp.eclass

[Ulrich Mueller (ulm)]

ulm         07/09/22 20:25:30

  Modified:             elisp-common.eclass elisp.eclass
  Log:
  Sync eclasses from Emacs overlay (revision 645).
  
  elisp.eclass:
  Die if elisp-install or elisp-site-file-install fails.
  Add man comments for variables SIMPLE_ELISP, DOCS, and NEED_EMACS.
  
  elisp-common.eclass:
  New variable EMACS_BATCH_CLEAN, analog to the XEmacs eclasses.
  Remove redundant pushd/popd commands in elisp-site-file-install;
  don't die, return status instead.
  Quote all instances of $@ and $*.
  Don't use ${status}; it is reserved in zsh.
  Call insinto and doins in a subshell to avoid pollution of calling
  environment.
  Remove superfluous dodir in elisp-install.
  Set no-byte-compile and provide site-gentoo in site-gentoo.el.
  Move comment for elisp-comp so that it will appear in the man page.

Revision  Changes    Path
1.28                 eclass/elisp-common.eclass

file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/elisp-common.eclass?rev=1.28&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/elisp-common.eclass?rev=1.28&content-type=text/plain
diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/elisp-common.eclass?r1=1.27&r2=1.28

Index: elisp-common.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/elisp-common.eclass,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- elisp-common.eclass	27 Aug 2007 19:41:03 -0000	1.27
+++ elisp-common.eclass	22 Sep 2007 20:25:30 -0000	1.28
@@ -1,6 +1,6 @@
 # Copyright 1999-2007 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/elisp-common.eclass,v 1.27 2007/08/27 19:41:03 ulm Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/elisp-common.eclass,v 1.28 2007/09/22 20:25:30 ulm Exp $
 #
 # Copyright 2007 Christian Faulhammer <opfer@g.o>
 # Copyright 2002-2004 Matthew Kennedy <mkennedy@g.o>
@@ -129,6 +129,9 @@
 
 SITELISP=/usr/share/emacs/site-lisp
 SITEFILE=50${PN}-gentoo.el
+EMACS=/usr/bin/emacs
+# The following works for Emacs versions 18-23, don't change it.
+EMACS_BATCH_CLEAN="${EMACS} -batch -q --no-site-file"
 
 # @FUNCTION: elisp-compile
 # @USAGE: <list of elisp files>
@@ -137,7 +140,7 @@
 
 elisp-compile() {
 	einfo "Compiling GNU Emacs Elisp files ..."
-	/usr/bin/emacs -batch -q --no-site-file -f batch-byte-compile $*
+	${EMACS_BATCH_CLEAN} -f batch-byte-compile "$@"
 }
 
 # @FUNCTION: elisp-emacs-version
@@ -145,9 +148,9 @@
 # Output version of currently active Emacs.
 
 elisp-emacs-version() {
-	# The following will work for at least versions 18-22.
+	# The following will work for at least versions 18-23.
 	echo "(princ emacs-version)" >"${T}"/emacs-version.el
-	/usr/bin/emacs -batch -q --no-site-file -l "${T}"/emacs-version.el
+	${EMACS_BATCH_CLEAN} -l "${T}"/emacs-version.el
 }
 
 # @FUNCTION: elisp-make-autoload-file
@@ -177,7 +180,7 @@
 	;;; ${f##*/} ends here
 	EOF
 
-	/usr/bin/emacs -batch -q --no-site-file \
+	${EMACS_BATCH_CLEAN} \
 		--eval "(setq make-backup-files nil)" \
 		--eval "(setq generated-autoload-file (expand-file-name \"${f}\"))" \
 		-f batch-update-autoloads "${@-.}"
@@ -189,12 +192,13 @@
 # Install files in SITELISP directory.
 
 elisp-install() {
-	local subdir=$1
-	einfo "Installing Elisp files for GNU Emacs support ..."
-	dodir "${SITELISP}/${subdir}"
-	insinto "${SITELISP}/${subdir}"
+	local subdir="$1"
 	shift
-	doins $@
+	einfo "Installing Elisp files for GNU Emacs support ..."
+	( # subshell to avoid pollution of calling environment
+		insinto "${SITELISP}/${subdir}"
+		doins "$@"
+	)
 }
 
 # @FUNCTION: elisp-site-file-install
@@ -203,14 +207,14 @@
 # Install Emacs site-init file in SITELISP directory.
 
 elisp-site-file-install() {
-	local sitefile=$1 my_pn=${2:-${PN}}
+	local sf="$1" my_pn="${2:-${PN}}"
 	einfo "Installing site initialisation file for GNU Emacs ..."
-	pushd "${S}"
-	cp ${sitefile} "${T}"
-	sed -i "s:@SITELISP@:${SITELISP}/${my_pn}:g" "${T}/$(basename ${sitefile})"
-	insinto ${SITELISP}
-	doins "${T}/$(basename ${sitefile})" || die "failed to install site file"
-	popd
+	cp "${sf}" "${T}"
+	sed -i "s:@SITELISP@:${SITELISP}/${my_pn}:g" "${T}/$(basename "${sf}")"
+	( # subshell to avoid pollution of calling environment
+		insinto "${SITELISP}"
+		doins "${T}/$(basename "${sf}")"
+	)
 }
 
 # @FUNCTION: elisp-site-regen
@@ -240,6 +244,11 @@
 
 	cat <<-EOF >>"${T}"/site-gentoo.el
 
+	(provide 'site-gentoo)
+
+	;; Local Variables:
+	;; no-byte-compile: t
+	;; End:
 	;;; site-gentoo.el ends here
 	EOF
 
@@ -279,19 +288,20 @@
 # @USAGE: <list of elisp files>
 # @DESCRIPTION:
 # Byte-compile interdependent Emacs Lisp files.
-# Originally taken from GNU autotools.
+#
+# This function byte-compiles all ".el" files which are part of its
+# arguments, using GNU Emacs, and puts the resulting ".elc" files into the
+# current directory, so disregarding the original directories used in ".el"
+# arguments.
+#
+# This function manages in such a way that all Emacs Lisp files to be
+# compiled are made visible between themselves, in the event they require or
+# load one another.
 
 elisp-comp() {
 	# Copyright 1995 Free Software Foundation, Inc.
 	# François Pinard <pinard@×××××××××××××.ca>, 1995.
-	# This script byte-compiles all `.el' files which are part of its
-	# arguments, using GNU Emacs, and put the resulting `.elc' files into
-	# the current directory, so disregarding the original directories used
-	# in `.el' arguments.
-	#
-	# This script manages in such a way that all Emacs LISP files to
-	# be compiled are made visible between themselves, in the event
-	# they require or load-library one another.
+	# Originally taken from GNU autotools.
 
 	test $# -gt 0 || return 1
 
@@ -304,16 +314,15 @@
 
 	tempdir=elc.$$
 	mkdir ${tempdir}
-	cp $* ${tempdir}
+	cp "$@" ${tempdir}
 	pushd ${tempdir}
 
 	echo "(add-to-list 'load-path \"../\")" > script
-	${EMACS} -batch -q --no-site-file --no-init-file -l script \
-		-f batch-byte-compile *.el
-	local status=$?
+	${EMACS_BATCH_CLEAN} -l script -f batch-byte-compile *.el
+	local ret=$?
 	mv *.elc ..
 
 	popd
 	rm -fr ${tempdir}
-	return ${status}
+	return ${ret}
 }



1.23                 eclass/elisp.eclass

file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/elisp.eclass?rev=1.23&view=markup
plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/elisp.eclass?rev=1.23&content-type=text/plain
diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/elisp.eclass?r1=1.22&r2=1.23

Index: elisp.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/elisp.eclass,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- elisp.eclass	27 Aug 2007 19:41:03 -0000	1.22
+++ elisp.eclass	22 Sep 2007 20:25:30 -0000	1.23
@@ -1,6 +1,6 @@
 # Copyright 1999-2007 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/elisp.eclass,v 1.22 2007/08/27 19:41:03 ulm Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/elisp.eclass,v 1.23 2007/09/22 20:25:30 ulm Exp $
 #
 # Copyright 2007 Christian Faulhammer <opfer@g.o>
 # Copyright 2002-2003 Matthew Kennedy <mkennedy@g.o>
@@ -18,15 +18,21 @@
 # Emacs support for other than pure elisp packages is handled by
 # elisp-common.eclass where you won't have a dependency on Emacs itself.
 # All elisp-* functions are documented there.
-#
+
+# @ECLASS-VARIABLE: SIMPLE_ELISP
+# @DESCRIPTION:
 # Setting SIMPLE_ELISP=t in an ebuild means, that the package's source
 # is a single (in whatever way) compressed elisp file with the file name
 # ${PN}-${PV}.  This eclass will then redefine ${S}, and move
 # ${PN}-${PV}.el to ${PN}.el in src_unpack().
-#
+
+# @ECLASS-VARIABLE: DOCS
+# @DESCRIPTION:
 # DOCS="blah.txt ChangeLog" is automatically used to install the given
 # files by dodoc in src_install().
-#
+
+# @ECLASS-VARIABLE: NEED_EMACS
+# @DESCRIPTION:
 # If you need anything different from Emacs 21, use the NEED_EMACS
 # variable before inheriting elisp.eclass.  Set it to the major version
 # your package uses and the dependency will be adjusted.
@@ -63,8 +69,9 @@
 }
 
 elisp_src_install() {
-	elisp-install ${PN} *.el *.elc
-	elisp-site-file-install "${FILESDIR}/${SITEFILE}"
+	elisp-install ${PN} *.el *.elc || die "elisp-install failed"
+	elisp-site-file-install "${FILESDIR}/${SITEFILE}" \
+		|| die "elisp-site-file-install failed"
 	if [ -n "${DOCS}" ]; then
 		dodoc ${DOCS} || die "dodoc failed"
 	fi



-- 
gentoo-commits@g.o mailing list