[gentoo-commits] gentoo-x86 commit in eclass: ruby-fakegem.eclass ruby-ng.eclass

[Diego Petteno (flameeyes)]

flameeyes    10/08/30 22:08:24

  Modified:             ruby-fakegem.eclass ruby-ng.eclass
  Log:
  Factor out the ree18→rubyee18 conversion and use it when generating the binwrapper (closes bug #335328).

Revision  Changes    Path
1.23                 eclass/ruby-fakegem.eclass

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ruby-fakegem.eclass?rev=1.23&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ruby-fakegem.eclass?rev=1.23&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ruby-fakegem.eclass?r1=1.22&r2=1.23

Index: ruby-fakegem.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/ruby-fakegem.eclass,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- ruby-fakegem.eclass	29 Jul 2010 09:38:09 -0000	1.22
+++ ruby-fakegem.eclass	30 Aug 2010 22:08:24 -0000	1.23
@@ -1,6 +1,6 @@
 # Copyright 1999-2009 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/ruby-fakegem.eclass,v 1.22 2010/07/29 09:38:09 flameeyes Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/ruby-fakegem.eclass,v 1.23 2010/08/30 22:08:24 flameeyes Exp $
 #
 # @ECLASS: ruby-fakegem.eclass
 # @MAINTAINER:
@@ -152,7 +152,7 @@
 		# so better taking this into consideration.
 		local quoted_description=${DESCRIPTION//\"/\\\"}
 		cat - > "${T}"/${RUBY_FAKEGEM_NAME}-${_ruby_implementation} <<EOF
-# generated by ruby-fakegem.eclass $Revision: 1.22 $
+# generated by ruby-fakegem.eclass $Revision: 1.23 $
 Gem::Specification.new do |s|
   s.name = "${RUBY_FAKEGEM_NAME}"
   s.version = "${RUBY_FAKEGEM_VERSION}"
@@ -192,7 +192,7 @@
 			use ruby_targets_${implementation} || continue
 			if [ -z $rubycmd ]; then
 				# if no other implementation was set before, set it.
-				rubycmd="/usr/bin/${implementation}"
+				rubycmd="$(ruby_implementation_command ${implementation})"
 			else
 				# if another implementation already arrived, then make
 				# it generic and break out of the loop. This ensures
@@ -206,7 +206,7 @@
 #!${rubycmd}
 # This is a simplified version of the RubyGems wrapper
 #
-# Generated by ruby-fakegem.eclass $Revision: 1.22 $
+# Generated by ruby-fakegem.eclass $Revision: 1.23 $
 
 require 'rubygems'
 



1.27                 eclass/ruby-ng.eclass

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ruby-ng.eclass?rev=1.27&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ruby-ng.eclass?rev=1.27&content-type=text/plain
diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ruby-ng.eclass?r1=1.26&r2=1.27

Index: ruby-ng.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/ruby-ng.eclass,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- ruby-ng.eclass	22 Aug 2010 07:28:24 -0000	1.26
+++ ruby-ng.eclass	30 Aug 2010 22:08:24 -0000	1.27
@@ -1,6 +1,6 @@
 # Copyright 1999-2009 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/ruby-ng.eclass,v 1.26 2010/08/22 07:28:24 graaff Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/ruby-ng.eclass,v 1.27 2010/08/30 22:08:24 flameeyes Exp $
 #
 # @ECLASS: ruby-ng.eclass
 # @MAINTAINER:
@@ -131,6 +131,25 @@
 	eshopts_pop
 }
 
+# @FUNCTION: ruby_implementation_command
+# @RETURN: the path to the given ruby implementation
+# @DESCRIPTION:
+# Not all implementations have the same command basename as the
+# target; namely Ruby Enterprise 1.8 uses ree18 and rubyee18
+# respectively. This function translate between the two
+ruby_implementation_command() {
+	local _ruby_name=$1
+
+		# Add all USE_RUBY values where the flag name diverts from the binary here
+	case $1 in
+		ree18)
+			_ruby_name=rubyee18
+			;;
+	esac
+
+	echo $(type -p ${_ruby_name} 2>/dev/null)
+}
+
 _ruby_atoms_samelib() {
 	local atoms=$(_ruby_atoms_samelib_generic "$*")
 
@@ -263,20 +282,11 @@
 		# only proceed if it's requested
 		use ruby_targets_${_ruby_implementation} || continue
 
-		local _ruby_name=$_ruby_implementation
-
-		# Add all USE_RUBY values where the flag name diverts from the binary here
-		case $_ruby_implementation in
-			ree18)
-				_ruby_name=rubyee18
-				;;
-		esac
-
-		RUBY=$(type -p $_ruby_name 2>/dev/null)
+		RUBY=$(ruby_implementation_command ${_ruby_implementation})
 		invoked=yes
 
 		if [[ -n "$1" ]]; then
-			_ruby_invoke_environment $_ruby_implementation "$@"
+			_ruby_invoke_environment ${_ruby_implementation} "$@"
 		fi
 
 		unset RUBY