Gentoo Archives: gentoo-commits

From: Marek Szuba <marecki@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: games-strategy/widelands/
Date: Wed, 02 Dec 2020 23:08:26
Message-Id: 1606950493.c3b5eb39349d14067bcce3f3bb9398f90fbb2373.marecki@gentoo
1 commit: c3b5eb39349d14067bcce3f3bb9398f90fbb2373
2 Author: Marek Szuba <marecki <AT> gentoo <DOT> org>
3 AuthorDate: Wed Dec 2 22:54:29 2020 +0000
4 Commit: Marek Szuba <marecki <AT> gentoo <DOT> org>
5 CommitDate: Wed Dec 2 23:08:13 2020 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3b5eb39
7
8 games-strategy/widelands: Do not depend on dev-lang/lua
9
10 Short version: this package builds, tests and installs without any
11 errors on systems without any versions of Lua installed, and even when a
12 copy of Lua *is* installed does not interact with it in any way (which
13 was already reflected by the fact dev-lang/lua was not mentioned in
14 RDEPEND, only in DEPEND).
15
16 Details:
17
18 Widelands source code comes bundled with Lua - or to be precise with
19 Eris (https://github.com/fnuecke/eris), which according to its upstream
20 should be considered "a custom 'distribution' of Lua" due to the fact it
21 hooks heavily into Lua internals. Since src/third_party/eris/README.eris
22 explicitly states that the bundled Eris is what brings in the Lua
23 version used in Widelands, it is no surprise that upstream build scripts
24 do not even attempt to look for system Lua.
25
26 Bug: https://bugs.gentoo.org/752729
27 Signed-off-by: Marek Szuba <marecki <AT> gentoo.org>
28
29 games-strategy/widelands/widelands-0.20-r1.ebuild | 1 -
30 games-strategy/widelands/widelands-9999.ebuild | 1 -
31 2 files changed, 2 deletions(-)
32
33 diff --git a/games-strategy/widelands/widelands-0.20-r1.ebuild b/games-strategy/widelands/widelands-0.20-r1.ebuild
34 index c0629174bc7..c01f32953ab 100644
35 --- a/games-strategy/widelands/widelands-0.20-r1.ebuild
36 +++ b/games-strategy/widelands/widelands-0.20-r1.ebuild
37 @@ -32,7 +32,6 @@ RDEPEND="
38 sys-libs/zlib:=[minizip]"
39 DEPEND="${RDEPEND}
40 ${PYTHON_DEPS}
41 - dev-lang/lua:0
42 "
43 BDEPEND="
44 sys-devel/gettext
45
46 diff --git a/games-strategy/widelands/widelands-9999.ebuild b/games-strategy/widelands/widelands-9999.ebuild
47 index 15743092919..33ade68e2d5 100644
48 --- a/games-strategy/widelands/widelands-9999.ebuild
49 +++ b/games-strategy/widelands/widelands-9999.ebuild
50 @@ -39,7 +39,6 @@ RDEPEND="
51 sys-libs/zlib:=[minizip]"
52 DEPEND="${RDEPEND}
53 ${PYTHON_DEPS}
54 - dev-lang/lua:0
55 "
56 BDEPEND="
57 sys-devel/gettext