Gentoo Archives: gentoo-commits

From: Brian Dolbec <brian.dolbec@×××××.com>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage:master commit in: bin/install-qa-check.d/
Date: Tue, 02 Dec 2014 18:44:08
Message-Id: 1417545646.64aae90b942edb4a51ac3eed13dbcbe3e20199fb.dol-sen@gentoo
1 commit: 64aae90b942edb4a51ac3eed13dbcbe3e20199fb
2 Author: Michael Palimaka <kensington <AT> gentoo <DOT> org>
3 AuthorDate: Fri Nov 21 16:50:40 2014 +0000
4 Commit: Brian Dolbec <brian.dolbec <AT> gmail <DOT> com>
5 CommitDate: Tue Dec 2 18:40:46 2014 +0000
6 URL: http://sources.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=64aae90b
7
8 install-qa-check.d/90world-writable: fix usage of missing function
9
10 Fixes: 6dafdc28897682f7b8c77b7863b5713634974647
11 Subject: Remove __eqalog & __eqawarnlog
12 Author: Michał Górny <mgorny <AT> gentoo.org> (Sun 02 Nov 2014 11:16:04 AM PST)
13
14 As per Zmedico:
15 This file also contains an invalid IFS=OLDIFS setting (which should
16 really be IFS=$OLDIFS).
17
18 ---
19 bin/install-qa-check.d/90world-writable | 7 +++----
20 1 file changed, 3 insertions(+), 4 deletions(-)
21
22 diff --git a/bin/install-qa-check.d/90world-writable b/bin/install-qa-check.d/90world-writable
23 index 2b435ac..820683b 100644
24 --- a/bin/install-qa-check.d/90world-writable
25 +++ b/bin/install-qa-check.d/90world-writable
26 @@ -23,13 +23,12 @@ world_writable_check() {
27 if [[ -n ${unsafe_files} ]] ; then
28 eqawarn "QA Notice: Unsafe files detected (set*id and world writable)"
29
30 - for x in $unsafe_files ; do
31 - __eqawarnlog world-writable-setid "$x"
32 - done
33 + eqatag -v world-writable-setid $unsafe_files
34 +
35 die "Unsafe files found in \${D}. Portage will not install them."
36 fi
37
38 - IFS=OLDIFS
39 + IFS=$OLDIFS
40 [[ ${prev_shopts} == *f* ]] || set +f
41 }