Gentoo Archives: gentoo-commits

From: Fabian Groffen <grobian@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage-utils:master commit in: tests/atom_compare/
Date: Thu, 05 Apr 2018 13:31:19
Message-Id: 1522934850.5fc7da2079b2e04b5a0dd66e57ff9545ab54069d.grobian@gentoo
1 commit: 5fc7da2079b2e04b5a0dd66e57ff9545ab54069d
2 Author: Fabian Groffen <grobian <AT> gentoo <DOT> org>
3 AuthorDate: Thu Apr 5 13:27:30 2018 +0000
4 Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org>
5 CommitDate: Thu Apr 5 13:27:30 2018 +0000
6 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=5fc7da20
7
8 tests/atom_compare/Makefile: fail when there are differences
9
10 The static tests fell off the radar because actual differences did not
11 result in failure (e.g. Travis being green and all), also the sed magic
12 was too loose, causing a wrong input file to be computed
13
14 tests/atom_compare/Makefile | 3 ++-
15 1 file changed, 2 insertions(+), 1 deletion(-)
16
17 diff --git a/tests/atom_compare/Makefile b/tests/atom_compare/Makefile
18 index 71a980f..ead9d75 100644
19 --- a/tests/atom_compare/Makefile
20 +++ b/tests/atom_compare/Makefile
21 @@ -8,7 +8,7 @@ test check: static static.q portage
22 t = \
23 @set -f && \
24 $(call mkdir,$(b)) && \
25 - good=`echo $< | sed 's:.tests:.good:'`; \
26 + good=`echo $< | sed 's:.tests$$:.good:'`; \
27 out=$(@:.tests=); \
28 ret=0; \
29 $(realpath $(lastword $^)) $(1) `sed 's:\#.*::' $<` > $$out || ret=$$?; \
30 @@ -18,6 +18,7 @@ t = \
31 echo "PASS atom_compare $$out"; \
32 else \
33 echo "FAIL atom_compare $$out"; \
34 + ret=1; \
35 fi;; \
36 77) echo "SKIP atom_compare $$out"; ret=0;; \
37 *) echo "FAIL atom_compare $$out";; \