Gentoo Archives: gentoo-commits

From: "Robin H. Johnson" <robbat2@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/netifrc:master commit in: mk/
Date: Sun, 21 Apr 2019 05:34:06
Message-Id: 1555823809.7a7e77357cca8d3e530cb96cf7a6ea0d879ba8e6.robbat2@OpenRC
1 commit: 7a7e77357cca8d3e530cb96cf7a6ea0d879ba8e6
2 Author: Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
3 AuthorDate: Sun Apr 21 05:16:49 2019 +0000
4 Commit: Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
5 CommitDate: Sun Apr 21 05:16:49 2019 +0000
6 URL: https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=7a7e7735
7
8 shellcheck: turn off some checks to start
9
10 Signed-off-by: Robin H. Johnson <robbat2 <AT> gentoo.org>
11
12 mk/scripts.mk | 13 ++++++++++---
13 1 file changed, 10 insertions(+), 3 deletions(-)
14
15 diff --git a/mk/scripts.mk b/mk/scripts.mk
16 index 7e512f0..d278ac1 100644
17 --- a/mk/scripts.mk
18 +++ b/mk/scripts.mk
19 @@ -14,7 +14,13 @@ _LCL_SED:= $(shell ${_LCL_SED_SH})
20
21 SED_REPLACE= -e 's:@SHELL@:${SH}:g' -e 's:@LIB@:${LIBNAME}:g' -e 's:@SYSCONFDIR@:${SYSCONFDIR}:g' -e 's:@CONFDIR@:${CONFDIR}:g' -e 's:@LIBEXECDIR@:${LIBEXECDIR}:g' -e 's:@PREFIX@:${PREFIX}:g' -e 's:@BINDIR@:${BINDIR}:g' -e 's:@SBINDIR@:${SBINDIR}:g' -e 's:@INITDIR@:${INITDIR}:g' ${_PKG_SED} ${_LCL_SED}
22
23 -SHELLCHECK_CMD = shellcheck -s sh --exclude SC1008 -f gcc
24 +# SC1008: shebang
25 +# SC2039: warning: In POSIX sh, 'local' is undefined.
26 +# SC2086: splitting
27 +# SC2155: declare/assign
28 +# warning: domain is referenced but not assigned. [SC2154]
29 +# note: Don't use variables in the printf format string. Use printf "..%s.." "$foo". [SC2059]
30 +SHELLCHECK_CMD = shellcheck -s sh --exclude SC1008,SC2039,SC2086,SC2155,SC2154,SC2059 -f gcc
31
32 # Tweak our shell scripts
33 %.sh: %.sh.in
34 @@ -57,7 +63,8 @@ CLEANFILES+= ${OBJS}
35 clean:
36 @if test -n "${CLEANFILES}"; then echo "rm -f ${CLEANFILES}"; rm -f ${CLEANFILES}; fi
37
38 -shellcheck: ${SRCS}
39 - @$(SHELLCHECK_CMD) $<
40 +shellcheck: $(filter net.lo.in net.example.in %.sh.in, ${SRCS}) $(filter %.sh, ${INC})
41 + @${ECHO} CHECKING $^
42 + @$(SHELLCHECK_CMD) $^
43
44 include ${MK}/gitignore.mk