Gentoo Archives: gentoo-commits

From: Lars Wendler <polynomial-c@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-apps/ipmitool/files/
Date: Fri, 26 Feb 2021 16:41:39
Message-Id: 1614357691.18bd451e5f29a1d94d4c4320fbac5c007f1098e4.polynomial-c@gentoo
1 commit: 18bd451e5f29a1d94d4c4320fbac5c007f1098e4
2 Author: Michael Mair-Keimberger <mmk <AT> levelnine <DOT> at>
3 AuthorDate: Mon Feb 22 16:33:42 2021 +0000
4 Commit: Lars Wendler <polynomial-c <AT> gentoo <DOT> org>
5 CommitDate: Fri Feb 26 16:41:31 2021 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=18bd451e
7
8 sys-apps/ipmitool: remove unused patches
9
10 Package-Manager: Portage-3.0.14, Repoman-3.0.2
11 Signed-off-by: Michael Mair-Keimberger <mmk <AT> levelnine.at>
12 Closes: https://github.com/gentoo/gentoo/pull/19598
13 Signed-off-by: Lars Wendler <polynomial-c <AT> gentoo.org>
14
15 .../files/ipmitool-1.8.18-fno-common.patch | 22 ----
16 .../files/ipmitool-1.8.18-openssl-1.1.patch | 145 ---------------------
17 2 files changed, 167 deletions(-)
18
19 diff --git a/sys-apps/ipmitool/files/ipmitool-1.8.18-fno-common.patch b/sys-apps/ipmitool/files/ipmitool-1.8.18-fno-common.patch
20 deleted file mode 100644
21 index 5ca554961ca..00000000000
22 --- a/sys-apps/ipmitool/files/ipmitool-1.8.18-fno-common.patch
23 +++ /dev/null
24 @@ -1,22 +0,0 @@
25 ---- a/include/ipmitool/ipmi_hpmfwupg.h
26 -+++ b/include/ipmitool/ipmi_hpmfwupg.h
27 -@@ -800,8 +800,6 @@
28 - char descString[HPMFWUPG_DESC_STRING_LENGTH + 1];
29 - }VERSIONINFO, *PVERSIONINFO;
30 -
31 --VERSIONINFO gVersionInfo[HPMFWUPG_COMPONENT_ID_MAX];
32 --
33 - #define TARGET_VER (0x01)
34 - #define ROLLBACK_VER (0x02)
35 - #define IMAGE_VER (0x04)
36 ---- a/lib/ipmi_hpmfwupg.c
37 -+++ b/lib/ipmi_hpmfwupg.c
38 -@@ -52,6 +52,8 @@
39 - # include <config.h>
40 - #endif
41 -
42 -+static VERSIONINFO gVersionInfo[HPMFWUPG_COMPONENT_ID_MAX];
43 -+
44 - /* From src/plugins/ipmi_intf.c: */
45 - uint16_t
46 - ipmi_intf_get_max_request_data_size(struct ipmi_intf * intf);
47
48 diff --git a/sys-apps/ipmitool/files/ipmitool-1.8.18-openssl-1.1.patch b/sys-apps/ipmitool/files/ipmitool-1.8.18-openssl-1.1.patch
49 deleted file mode 100644
50 index 9e5a876f00a..00000000000
51 --- a/sys-apps/ipmitool/files/ipmitool-1.8.18-openssl-1.1.patch
52 +++ /dev/null
53 @@ -1,145 +0,0 @@
54 -Taken from various upstream commits:
55 -
56 -https://github.com/ipmitool/ipmitool/commit/b57487e360916ab3eaa50aa6d021c73b6337a4a0
57 -https://github.com/ipmitool/ipmitool/commit/77fe5635037ebaf411cae46cf5045ca819b5c145
58 -https://github.com/ipmitool/ipmitool/commit/f004b4b7197fc83e7d47ec8cbcaefffa9a922717
59 -https://github.com/ipmitool/ipmitool/commit/f004b4b7197fc83e7d47ec8cbcaefffa9a922717
60 -
61 ---- ipmitool-1.8.18/src/plugins/lanplus/lanplus_crypt_impl.c
62 -+++ ipmitool-1.8.18/src/plugins/lanplus/lanplus_crypt_impl.c
63 -@@ -164,11 +164,7 @@
64 - uint8_t * output,
65 - uint32_t * bytes_written)
66 - {
67 -- EVP_CIPHER_CTX ctx;
68 -- EVP_CIPHER_CTX_init(&ctx);
69 -- EVP_EncryptInit_ex(&ctx, EVP_aes_128_cbc(), NULL, key, iv);
70 -- EVP_CIPHER_CTX_set_padding(&ctx, 0);
71 --
72 -+ EVP_CIPHER_CTX *ctx = NULL;
73 -
74 - *bytes_written = 0;
75 -
76 -@@ -182,6 +178,14 @@
77 - printbuf(input, input_length, "encrypting this data");
78 - }
79 -
80 -+ ctx = EVP_CIPHER_CTX_new();
81 -+ if (ctx == NULL) {
82 -+ lprintf(LOG_DEBUG, "ERROR: EVP_CIPHER_CTX_new() failed");
83 -+ return;
84 -+ }
85 -+ EVP_CIPHER_CTX_init(ctx);
86 -+ EVP_EncryptInit_ex(ctx, EVP_aes_128_cbc(), NULL, key, iv);
87 -+ EVP_CIPHER_CTX_set_padding(ctx, 0);
88 -
89 - /*
90 - * The default implementation adds a whole block of padding if the input
91 -@@ -191,28 +195,28 @@
92 - assert((input_length % IPMI_CRYPT_AES_CBC_128_BLOCK_SIZE) == 0);
93 -
94 -
95 -- if(!EVP_EncryptUpdate(&ctx, output, (int *)bytes_written, input, input_length))
96 -+ if(!EVP_EncryptUpdate(ctx, output, (int *)bytes_written, input, input_length))
97 - {
98 - /* Error */
99 - *bytes_written = 0;
100 -- return;
101 - }
102 - else
103 - {
104 - uint32_t tmplen;
105 -
106 -- if(!EVP_EncryptFinal_ex(&ctx, output + *bytes_written, (int *)&tmplen))
107 -+ if(!EVP_EncryptFinal_ex(ctx, output + *bytes_written, (int *)&tmplen))
108 - {
109 -+ /* Error */
110 - *bytes_written = 0;
111 -- return; /* Error */
112 - }
113 - else
114 - {
115 - /* Success */
116 - *bytes_written += tmplen;
117 -- EVP_CIPHER_CTX_cleanup(&ctx);
118 - }
119 - }
120 -+ /* performs cleanup and free */
121 -+ EVP_CIPHER_CTX_free(ctx);
122 - }
123 -
124 -
125 -@@ -239,11 +243,7 @@
126 - uint8_t * output,
127 - uint32_t * bytes_written)
128 - {
129 -- EVP_CIPHER_CTX ctx;
130 -- EVP_CIPHER_CTX_init(&ctx);
131 -- EVP_DecryptInit_ex(&ctx, EVP_aes_128_cbc(), NULL, key, iv);
132 -- EVP_CIPHER_CTX_set_padding(&ctx, 0);
133 --
134 -+ EVP_CIPHER_CTX *ctx = NULL;
135 -
136 - if (verbose >= 5)
137 - {
138 -@@ -252,12 +252,20 @@
139 - printbuf(input, input_length, "decrypting this data");
140 - }
141 -
142 --
143 - *bytes_written = 0;
144 -
145 - if (input_length == 0)
146 - return;
147 -
148 -+ ctx = EVP_CIPHER_CTX_new();
149 -+ if (ctx == NULL) {
150 -+ lprintf(LOG_DEBUG, "ERROR: EVP_CIPHER_CTX_new() failed");
151 -+ return;
152 -+ }
153 -+ EVP_CIPHER_CTX_init(ctx);
154 -+ EVP_DecryptInit_ex(ctx, EVP_aes_128_cbc(), NULL, key, iv);
155 -+ EVP_CIPHER_CTX_set_padding(ctx, 0);
156 -+
157 - /*
158 - * The default implementation adds a whole block of padding if the input
159 - * data is perfectly aligned. We would like to keep that from happening.
160 -@@ -266,33 +274,33 @@
161 - assert((input_length % IPMI_CRYPT_AES_CBC_128_BLOCK_SIZE) == 0);
162 -
163 -
164 -- if (!EVP_DecryptUpdate(&ctx, output, (int *)bytes_written, input, input_length))
165 -+ if (!EVP_DecryptUpdate(ctx, output, (int *)bytes_written, input, input_length))
166 - {
167 - /* Error */
168 - lprintf(LOG_DEBUG, "ERROR: decrypt update failed");
169 - *bytes_written = 0;
170 -- return;
171 - }
172 - else
173 - {
174 - uint32_t tmplen;
175 -
176 -- if (!EVP_DecryptFinal_ex(&ctx, output + *bytes_written, (int *)&tmplen))
177 -+ if (!EVP_DecryptFinal_ex(ctx, output + *bytes_written, (int *)&tmplen))
178 - {
179 -+ /* Error */
180 - char buffer[1000];
181 - ERR_error_string(ERR_get_error(), buffer);
182 - lprintf(LOG_DEBUG, "the ERR error %s", buffer);
183 - lprintf(LOG_DEBUG, "ERROR: decrypt final failed");
184 - *bytes_written = 0;
185 -- return; /* Error */
186 - }
187 - else
188 - {
189 - /* Success */
190 - *bytes_written += tmplen;
191 -- EVP_CIPHER_CTX_cleanup(&ctx);
192 - }
193 - }
194 -+ /* performs cleanup and free */
195 -+ EVP_CIPHER_CTX_free(ctx);
196 -
197 - if (verbose >= 5)
198 - {