1 |
commit: 7b54f926721074aced28664f5d8080dbc3a1d674 |
2 |
Author: Ulrich Müller <ulm <AT> gentoo <DOT> org> |
3 |
AuthorDate: Sun Dec 10 23:42:43 2017 +0000 |
4 |
Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org> |
5 |
CommitDate: Sun Dec 10 23:56:49 2017 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b54f926 |
7 |
|
8 |
app-editors/emacs: Fix build failure with 17.0 profiles. |
9 |
|
10 |
The following comment from upstream is in configure.ac of emacs-25.3: |
11 |
"-no-pie or -nopie fixes a temacs segfault on Gentoo, OpenBSD, Ubuntu, |
12 |
and other systems with "hardened" GCC configurations for some reason |
13 |
(Bug#18784). We don't know why this works, but not segfaulting is |
14 |
better than segfaulting." |
15 |
|
16 |
Adding -no-pie to 23.4 and 24.5 appears to make them build, too. |
17 |
Note that only append-ldflags fixes the build failure, while |
18 |
append-flags does not (at least not for 23.4). |
19 |
|
20 |
Thanks to Mats Lidell for pointing me to the above upstream comment. |
21 |
|
22 |
Closes: https://bugs.gentoo.org/639568 |
23 |
Closes: https://bugs.gentoo.org/639570 |
24 |
Package-Manager: Portage-2.3.17, Repoman-2.3.6 |
25 |
|
26 |
app-editors/emacs/emacs-23.4-r16.ebuild | 1 + |
27 |
app-editors/emacs/emacs-24.5-r4.ebuild | 1 + |
28 |
2 files changed, 2 insertions(+) |
29 |
|
30 |
diff --git a/app-editors/emacs/emacs-23.4-r16.ebuild b/app-editors/emacs/emacs-23.4-r16.ebuild |
31 |
index 210f81f1618..230f36053ce 100644 |
32 |
--- a/app-editors/emacs/emacs-23.4-r16.ebuild |
33 |
+++ b/app-editors/emacs/emacs-23.4-r16.ebuild |
34 |
@@ -104,6 +104,7 @@ src_configure() { |
35 |
strip-flags |
36 |
filter-flags -fstrict-aliasing -pie |
37 |
append-flags $(test-flags -fno-strict-aliasing) |
38 |
+ append-ldflags $(test-flags -no-pie) #639568 |
39 |
|
40 |
if use sh; then |
41 |
replace-flags "-O[1-9]" -O0 #262359 |
42 |
|
43 |
diff --git a/app-editors/emacs/emacs-24.5-r4.ebuild b/app-editors/emacs/emacs-24.5-r4.ebuild |
44 |
index 12bb3ccaf3b..1dd73ddaf8c 100644 |
45 |
--- a/app-editors/emacs/emacs-24.5-r4.ebuild |
46 |
+++ b/app-editors/emacs/emacs-24.5-r4.ebuild |
47 |
@@ -97,6 +97,7 @@ src_prepare() { |
48 |
src_configure() { |
49 |
strip-flags |
50 |
filter-flags -pie #526948 |
51 |
+ append-ldflags $(test-flags -no-pie) #639570 |
52 |
|
53 |
if use sh; then |
54 |
replace-flags "-O[1-9]" -O0 #262359 |