Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-apps/konqueror/files/
Date: Tue, 23 Aug 2022 14:30:26
Message-Id: 1661265012.08b09d949611072b3bfcdaed5907778abe82ad5e.asturm@gentoo
1 commit: 08b09d949611072b3bfcdaed5907778abe82ad5e
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Tue Aug 23 14:25:50 2022 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Tue Aug 23 14:30:12 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=08b09d94
7
8 kde-apps/konqueror: Add missing patch
9
10 Closes: https://bugs.gentoo.org/866147
11 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
12
13 .../files/konqueror-22.04.3-without_x11.patch | 126 +++++++++++++++++++++
14 1 file changed, 126 insertions(+)
15
16 diff --git a/kde-apps/konqueror/files/konqueror-22.04.3-without_x11.patch b/kde-apps/konqueror/files/konqueror-22.04.3-without_x11.patch
17 new file mode 100644
18 index 000000000000..ff1de8680e69
19 --- /dev/null
20 +++ b/kde-apps/konqueror/files/konqueror-22.04.3-without_x11.patch
21 @@ -0,0 +1,126 @@
22 +From 503557c54c6162970072f31cb84b0eb934d409d4 Mon Sep 17 00:00:00 2001
23 +From: Andreas Sturmlechner <asturm@g.o>
24 +Date: Sun, 31 Jul 2022 14:47:48 +0200
25 +Subject: [PATCH 1/2] Drop unused X11 dependency
26 +
27 +Signed-off-by: Andreas Sturmlechner <asturm@g.o>
28 +---
29 + CMakeLists.txt | 8 ++------
30 + src/CMakeLists.txt | 4 ----
31 + 2 files changed, 2 insertions(+), 10 deletions(-)
32 +
33 +diff --git a/CMakeLists.txt b/CMakeLists.txt
34 +index 838197be7..d9218ae06 100644
35 +--- a/CMakeLists.txt
36 ++++ b/CMakeLists.txt
37 +@@ -47,12 +47,8 @@ if(Qt5WebEngineWidgets_VERSION VERSION_LESS "5.14.0")
38 + add_definitions(-DWEBENGINEDOWNLOADITEM_USE_PATH)
39 + endif()
40 +
41 +-find_package(X11)
42 +-set(KONQ_HAVE_X11 ${X11_FOUND})
43 +-
44 +-if (X11_FOUND)
45 +- find_package(Qt5 REQUIRED X11Extras)
46 +-endif(X11_FOUND)
47 ++find_package(Qt5X11Extras)
48 ++set(KONQ_HAVE_X11 ${Qt5X11Extras_FOUND})
49 +
50 + add_definitions(
51 + -DQT_USE_QSTRINGBUILDER
52 +diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
53 +index 9a1343e04..286bc7da8 100644
54 +--- a/src/CMakeLists.txt
55 ++++ b/src/CMakeLists.txt
56 +@@ -113,10 +113,6 @@ target_link_libraries(kdeinit_konqueror
57 + KF5::SonnetUi
58 + )
59 +
60 +-if (X11_FOUND)
61 +- target_link_libraries(kdeinit_konqueror ${X11_LIBRARIES})
62 +-endif ()
63 +-
64 + if (KActivities_FOUND)
65 + target_link_libraries(kdeinit_konqueror KF5::Activities)
66 + endif (KActivities_FOUND)
67 +--
68 +2.35.1
69 +
70 +
71 +From ff0e19961f8345faea54e4f85057312b7ad7007d Mon Sep 17 00:00:00 2001
72 +From: Andreas Sturmlechner <asturm@g.o>
73 +Date: Sat, 27 Nov 2021 14:36:20 +0100
74 +Subject: [PATCH 2/2] Add CMake option to build WITHOUT_X11
75 +
76 +We want to be able to build without X11 support even if some of the
77 +used libraries may not work w/o Qt5X11Extras themselves yet or need
78 +to be built with X11 support for other reverse dependencies.
79 +
80 +KONQ_HAVE_X11 already exists and is set automagically so far, but
81 +using -DCMAKE_DISABLE_FIND_PACKAGE_Qt5X11Extras will break if any
82 +dependencies list Qt5X11Extras as required in their cmake config.
83 +
84 +Introducing this option means there is no behavior change by default,
85 +cmake will just skip finding Qt5X11Extras or adding unwanted features
86 +if the option is enabled.
87 +
88 +Signed-off-by: Andreas Sturmlechner <asturm@g.o>
89 +---
90 + CMakeLists.txt | 7 +++++--
91 + client/CMakeLists.txt | 4 ++--
92 + src/CMakeLists.txt | 4 ++--
93 + 3 files changed, 9 insertions(+), 6 deletions(-)
94 +
95 +diff --git a/CMakeLists.txt b/CMakeLists.txt
96 +index d9218ae06..71bc03ecb 100644
97 +--- a/CMakeLists.txt
98 ++++ b/CMakeLists.txt
99 +@@ -47,8 +47,11 @@ if(Qt5WebEngineWidgets_VERSION VERSION_LESS "5.14.0")
100 + add_definitions(-DWEBENGINEDOWNLOADITEM_USE_PATH)
101 + endif()
102 +
103 +-find_package(Qt5X11Extras)
104 +-set(KONQ_HAVE_X11 ${Qt5X11Extras_FOUND})
105 ++option(WITHOUT_X11 "Build without X11 integration (skips finding Qt5X11Extras)" OFF)
106 ++if(NOT WITHOUT_X11)
107 ++ find_package(Qt5X11Extras)
108 ++ set(KONQ_HAVE_X11 ${Qt5X11Extras_FOUND})
109 ++endif()
110 +
111 + add_definitions(
112 + -DQT_USE_QSTRINGBUILDER
113 +diff --git a/client/CMakeLists.txt b/client/CMakeLists.txt
114 +index 24aedb14c..3c32c86f3 100644
115 +--- a/client/CMakeLists.txt
116 ++++ b/client/CMakeLists.txt
117 +@@ -30,9 +30,9 @@ if (WIN32)
118 + else (WIN32)
119 + kf5_add_kdeinit_executable( kfmclient NOGUI ${kfmclient_SRCS})
120 + target_link_libraries(kdeinit_kfmclient ${kfmclient_LIBS})
121 +- if(X11_FOUND)
122 ++ if(KONQ_HAVE_X11)
123 + target_link_libraries(kdeinit_kfmclient Qt5::X11Extras)
124 +- endif(X11_FOUND)
125 ++ endif()
126 + install(TARGETS kdeinit_kfmclient ${KDE_INSTALL_TARGETS_DEFAULT_ARGS} )
127 + endif (WIN32)
128 +
129 +diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
130 +index 286bc7da8..500b9750c 100644
131 +--- a/src/CMakeLists.txt
132 ++++ b/src/CMakeLists.txt
133 +@@ -33,9 +33,9 @@ target_link_libraries(konquerorprivate
134 + KF5::KIOGui
135 + )
136 +
137 +-if(X11_FOUND)
138 ++if(KONQ_HAVE_X11)
139 + target_link_libraries(konquerorprivate Qt5::X11Extras)
140 +-endif(X11_FOUND)
141 ++endif()
142 +
143 +
144 + set_target_properties(konquerorprivate PROPERTIES VERSION ${KONQUEROR_LIB_VERSION} SOVERSION "5" )
145 +--
146 +2.35.1
147 +