Gentoo Archives: gentoo-commits

From: Matt Turner <mattst88@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/catalyst:master commit in: catalyst/
Date: Thu, 21 May 2020 20:25:41
Message-Id: 1589939377.8443f89f3c5dfbc011a333e90bfef772a95e47cd.mattst88@gentoo
1 commit: 8443f89f3c5dfbc011a333e90bfef772a95e47cd
2 Author: Matt Turner <mattst88 <AT> gentoo <DOT> org>
3 AuthorDate: Tue May 19 00:13:14 2020 +0000
4 Commit: Matt Turner <mattst88 <AT> gentoo <DOT> org>
5 CommitDate: Wed May 20 01:49:37 2020 +0000
6 URL: https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=8443f89f
7
8 catalyst: Verify config options against valid_config_file_values
9
10 Signed-off-by: Matt Turner <mattst88 <AT> gentoo.org>
11
12 catalyst/main.py | 10 ++++++++--
13 1 file changed, 8 insertions(+), 2 deletions(-)
14
15 diff --git a/catalyst/main.py b/catalyst/main.py
16 index 159fe454..543895c6 100644
17 --- a/catalyst/main.py
18 +++ b/catalyst/main.py
19 @@ -15,7 +15,8 @@ from DeComp.contents import ContentsMap
20
21 from catalyst import log
22 import catalyst.config
23 -from catalyst.defaults import confdefaults, option_messages, DEFAULT_CONFIG_FILE
24 +from catalyst.defaults import (confdefaults, option_messages,
25 + DEFAULT_CONFIG_FILE, valid_config_file_values)
26 from catalyst.support import CatalystError
27 from catalyst.version import get_version
28
29 @@ -34,7 +35,12 @@ def parse_config(config_files):
30 for config_file in config_files:
31 log.notice('Loading configuration file: %s', config_file)
32 try:
33 - conf_values.update(toml.load(config_file))
34 + config = toml.load(config_file)
35 + for key in config:
36 + if key not in valid_config_file_values:
37 + log.critical("Unknown option '%s' in config file %s",
38 + key, config_file)
39 + conf_values.update(config)
40 except Exception as e:
41 log.critical('Could not find parse configuration file: %s: %s',
42 config_file, e)