Gentoo Archives: gentoo-commits

From: David Seifert <soap@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-fs/btrfs-progs/files/
Date: Sat, 11 Feb 2017 20:17:07
Message-Id: 1486844103.6a4f743f7a934e4cb5d11842d890bd5f813c4daf.soap@gentoo
1 commit: 6a4f743f7a934e4cb5d11842d890bd5f813c4daf
2 Author: Michael Mair-Keimberger (asterix) <m.mairkeimberger <AT> gmail <DOT> com>
3 AuthorDate: Sat Feb 11 16:30:51 2017 +0000
4 Commit: David Seifert <soap <AT> gentoo <DOT> org>
5 CommitDate: Sat Feb 11 20:15:03 2017 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a4f743f
7
8 sys-fs/btrfs-progs: remove unused patches
9
10 Closes: https://github.com/gentoo/gentoo/pull/3914
11
12 ...ogs-0.19-convert-remove-used-space-update.patch | 30 -----
13 .../files/btrfs-progs-0.19-fix-underlinking.patch | 11 --
14 .../files/btrfs-progs-0.19-glibc212.patch | 17 ---
15 .../files/btrfs-progs-3.12-defrag-sockets.patch | 78 -----------
16 .../btrfs-progs-3.12-fix-send-subvol-492776.patch | 111 ----------------
17 .../files/btrfs-progs-3.14.1-arg_strtou64.patch | 146 ---------------------
18 6 files changed, 393 deletions(-)
19
20 diff --git a/sys-fs/btrfs-progs/files/btrfs-progs-0.19-convert-remove-used-space-update.patch b/sys-fs/btrfs-progs/files/btrfs-progs-0.19-convert-remove-used-space-update.patch
21 deleted file mode 100644
22 index e326f34af7..0000000000
23 --- a/sys-fs/btrfs-progs/files/btrfs-progs-0.19-convert-remove-used-space-update.patch
24 +++ /dev/null
25 @@ -1,30 +0,0 @@
26 ---- /var/tmp/portage/sys-fs/btrfs-progs-0.19/work/btrfs-progs-0.19/convert.c 2009-06-11 10:56:15.000000000 -0600
27 -+++ btrfs-progs-unstable/convert.c 2009-09-21 08:51:43.773575874 -0600
28 -@@ -370,7 +370,6 @@
29 - struct btrfs_extent_item *ei;
30 - u32 blocksize = root->sectorsize;
31 - u64 nbytes;
32 -- u64 bytes_used;
33 -
34 - if (disk_bytenr == 0) {
35 - ret = btrfs_insert_file_extent(trans, root, objectid,
36 -@@ -432,9 +431,6 @@
37 - nbytes = btrfs_stack_inode_nbytes(inode) + num_bytes;
38 - btrfs_set_stack_inode_nbytes(inode, nbytes);
39 -
40 -- bytes_used = btrfs_root_used(&root->root_item);
41 -- btrfs_set_root_used(&root->root_item, bytes_used + num_bytes);
42 --
43 - btrfs_release_path(root, &path);
44 -
45 - ins_key.objectid = disk_bytenr;
46 -@@ -454,9 +450,6 @@
47 -
48 - btrfs_mark_buffer_dirty(leaf);
49 -
50 -- bytes_used = btrfs_super_bytes_used(&info->super_copy);
51 -- btrfs_set_super_bytes_used(&info->super_copy, bytes_used +
52 -- num_bytes);
53 - ret = btrfs_update_block_group(trans, root, disk_bytenr,
54 - num_bytes, 1, 0);
55 - if (ret)
56
57 diff --git a/sys-fs/btrfs-progs/files/btrfs-progs-0.19-fix-underlinking.patch b/sys-fs/btrfs-progs/files/btrfs-progs-0.19-fix-underlinking.patch
58 deleted file mode 100644
59 index 38a0a18dbc..0000000000
60 --- a/sys-fs/btrfs-progs/files/btrfs-progs-0.19-fix-underlinking.patch
61 +++ /dev/null
62 @@ -1,11 +0,0 @@
63 ---- btrfs-progs-0.19/Makefile~ 2011-06-05 10:21:04.000000000 -0600
64 -+++ btrfs-progs-0.19/Makefile 2011-06-05 10:21:46.000000000 -0600
65 -@@ -75,7 +75,7 @@ quick-test: $(objects) quick-test.o
66 - gcc $(CFLAGS) -o quick-test $(objects) quick-test.o $(LDFLAGS) $(LIBS)
67 -
68 - convert: $(objects) convert.o
69 -- gcc $(CFLAGS) -o btrfs-convert $(objects) convert.o -lext2fs $(LDFLAGS) $(LIBS)
70 -+ gcc $(CFLAGS) -o btrfs-convert $(objects) convert.o -lext2fs -lcom_err $(LDFLAGS) $(LIBS)
71 -
72 - ioctl-test: $(objects) ioctl-test.o
73 - gcc $(CFLAGS) -o ioctl-test $(objects) ioctl-test.o $(LDFLAGS) $(LIBS)
74
75 diff --git a/sys-fs/btrfs-progs/files/btrfs-progs-0.19-glibc212.patch b/sys-fs/btrfs-progs/files/btrfs-progs-0.19-glibc212.patch
76 deleted file mode 100644
77 index 183fe2af3e..0000000000
78 --- a/sys-fs/btrfs-progs/files/btrfs-progs-0.19-glibc212.patch
79 +++ /dev/null
80 @@ -1,17 +0,0 @@
81 -btrfsck.o: In function `maybe_free_inode_rec':
82 -btrfsck.c:(.text+0xce6): undefined reference to `S_ISDIR'
83 -btrfsck.c:(.text+0xd13): undefined reference to `S_ISREG'
84 -btrfsck.c:(.text+0xdc7): undefined reference to `S_ISREG'
85 -btrfsck.c:(.text+0xe2e): undefined reference to `S_ISLNK'
86 -btrfsck.c:(.text+0xe5b): undefined reference to `S_ISLNK'
87 -
88 ---- btrfsck.c
89 -+++ btrfsck.c
90 -@@ -21,6 +21,7 @@
91 - #include <stdio.h>
92 - #include <stdlib.h>
93 - #include <fcntl.h>
94 -+#include <sys/stat.h>
95 - #include "kerncompat.h"
96 - #include "ctree.h"
97 - #include "disk-io.h"
98
99 diff --git a/sys-fs/btrfs-progs/files/btrfs-progs-3.12-defrag-sockets.patch b/sys-fs/btrfs-progs/files/btrfs-progs-3.12-defrag-sockets.patch
100 deleted file mode 100644
101 index e2feb0bdbe..0000000000
102 --- a/sys-fs/btrfs-progs/files/btrfs-progs-3.12-defrag-sockets.patch
103 +++ /dev/null
104 @@ -1,78 +0,0 @@
105 -From: Pascal VITOUX <vitoux.pascal@×××××.com>
106 -To: linux-btrfs@×××××××××××.org
107 -Cc: Pascal VITOUX <vitoux.pascal@×××××.com>
108 -Subject: [PATCH] btrfs-progs: skip non-regular files while defragmenting
109 -Date: Thu, 9 Jan 2014 23:47:14 +0100
110 -Message-Id: <1389307634-8226-1-git-send-email-vitoux.pascal@×××××.com>
111 -X-Mailer: git-send-email 1.8.5.2
112 -Sender: linux-btrfs-owner@×××××××××××.org
113 -Precedence: bulk
114 -List-ID: <linux-btrfs.vger.kernel.org>
115 -X-Mailing-List: linux-btrfs@×××××××××××.org
116 -
117 -Skip non-regular files to avoid ioctl errors while defragmenting.
118 -
119 -They are silently ignored in recursive mode but reported as errors when
120 -used as command-line arguments.
121 -
122 -Signed-off-by: Pascal VITOUX <vitoux.pascal@×××××.com>
123 -Gentoo-bug: https://bugs.gentoo.org/503514
124 -Reported-by: Antoine Lemoine
125 ----
126 - cmds-filesystem.c | 26 ++++++++++++++++----------
127 - 1 file changed, 16 insertions(+), 10 deletions(-)
128 -
129 -diff --git a/cmds-filesystem.c b/cmds-filesystem.c
130 -index 1c1926b..54fba10 100644
131 ---- a/cmds-filesystem.c
132 -+++ b/cmds-filesystem.c
133 -@@ -646,7 +646,7 @@ static int defrag_callback(const char *fpath, const struct stat *sb,
134 - int e = 0;
135 - int fd = 0;
136 -
137 -- if (typeflag == FTW_F) {
138 -+ if ((typeflag == FTW_F) && S_ISREG(sb->st_mode)) {
139 - if (defrag_global_verbose)
140 - printf("%s\n", fpath);
141 - fd = open(fpath, O_RDWR);
142 -@@ -748,6 +748,7 @@ static int cmd_defrag(int argc, char **argv)
143 - defrag_global_range.flags |= BTRFS_DEFRAG_RANGE_START_IO;
144 -
145 - for (i = optind; i < argc; i++) {
146 -+ struct stat st;
147 - dirstream = NULL;
148 - fd = open_file_or_dir(argv[i], &dirstream);
149 - if (fd < 0) {
150 -@@ -757,16 +758,21 @@ static int cmd_defrag(int argc, char **argv)
151 - close_file_or_dir(fd, dirstream);
152 - continue;
153 - }
154 -+ if (fstat(fd, &st)) {
155 -+ fprintf(stderr, "ERROR: failed to stat %s - %s\n",
156 -+ argv[i], strerror(errno));
157 -+ defrag_global_errors++;
158 -+ close_file_or_dir(fd, dirstream);
159 -+ continue;
160 -+ }
161 -+ if (!(S_ISDIR(st.st_mode) || S_ISREG(st.st_mode))) {
162 -+ fprintf(stderr, "ERROR: %s is not a directory or a regular "
163 -+ "file.\n", argv[i]);
164 -+ defrag_global_errors++;
165 -+ close_file_or_dir(fd, dirstream);
166 -+ continue;
167 -+ }
168 - if (recursive) {
169 -- struct stat st;
170 --
171 -- if (fstat(fd, &st)) {
172 -- fprintf(stderr, "ERROR: failed to stat %s - %s\n",
173 -- argv[i], strerror(errno));
174 -- defrag_global_errors++;
175 -- close_file_or_dir(fd, dirstream);
176 -- continue;
177 -- }
178 - if (S_ISDIR(st.st_mode)) {
179 - ret = nftw(argv[i], defrag_callback, 10,
180 - FTW_MOUNT | FTW_PHYS);
181 ---
182 -1.8.5.2
183
184 diff --git a/sys-fs/btrfs-progs/files/btrfs-progs-3.12-fix-send-subvol-492776.patch b/sys-fs/btrfs-progs/files/btrfs-progs-3.12-fix-send-subvol-492776.patch
185 deleted file mode 100644
186 index 8a2cc7883a..0000000000
187 --- a/sys-fs/btrfs-progs/files/btrfs-progs-3.12-fix-send-subvol-492776.patch
188 +++ /dev/null
189 @@ -1,111 +0,0 @@
190 -Gentoo-bug: http://bugs.gentoo.org/492776
191 -
192 -From: Wang Shilong <wangsl.fnst@××××××××××.com>
193 -
194 -Steps to reproduce:
195 - # mkfs.btrfs -f /dev/sda
196 - # mount /dev/sda /mnt
197 - # btrfs subvolume create /mnt/foo
198 - # umount /mnt
199 - # mount -o subvol=foo /dev/sda /mnt
200 - # btrfs sub snapshot -r /mnt /mnt/snap
201 - # btrfs send /mnt/snap > /dev/null
202 -
203 -We will fail to send '/mnt/snap',this is because btrfs send try to
204 -open '/mnt/snap' by btrfs internal subvolume path 'foo/snap' rather
205 -than relative path based on mounted point, this will return us 'no
206 -such file or directory',this is not right, fix it.
207 -
208 -Reported-by: Thomas Scheiblauer <tom@××××××××.at>
209 -Signed-off-by: Wang Shilong <wangsl.fnst@××××××××××.com>
210 ----
211 -v1->v2:
212 - code cleanups(thanks to Stefan)
213 ----
214 - cmds-send.c | 34 ++++++----------------------------
215 - 1 file changed, 6 insertions(+), 28 deletions(-)
216 -
217 -diff --git a/cmds-send.c b/cmds-send.c
218 -index 53e9a53..6fdfd7f 100644
219 ---- a/cmds-send.c
220 -+++ b/cmds-send.c
221 -@@ -282,31 +282,21 @@ out:
222 - return ERR_PTR(ret);
223 - }
224 -
225 --static int do_send(struct btrfs_send *send, u64 root_id, u64 parent_root_id,
226 -- int is_first_subvol, int is_last_subvol)
227 -+static int do_send(struct btrfs_send *send, u64 parent_root_id,
228 -+ int is_first_subvol, int is_last_subvol, char *subvol)
229 - {
230 - int ret;
231 - pthread_t t_read;
232 - pthread_attr_t t_attr;
233 - struct btrfs_ioctl_send_args io_send;
234 -- struct subvol_info *si;
235 - void *t_err = NULL;
236 - int subvol_fd = -1;
237 - int pipefd[2] = {-1, -1};
238 -
239 -- si = subvol_uuid_search(&send->sus, root_id, NULL, 0, NULL,
240 -- subvol_search_by_root_id);
241 -- if (!si) {
242 -- ret = -ENOENT;
243 -- fprintf(stderr, "ERROR: could not find subvol info for %llu",
244 -- root_id);
245 -- goto out;
246 -- }
247 --
248 -- subvol_fd = openat(send->mnt_fd, si->path, O_RDONLY | O_NOATIME);
249 -+ subvol_fd = openat(send->mnt_fd, subvol, O_RDONLY | O_NOATIME);
250 - if (subvol_fd < 0) {
251 - ret = -errno;
252 -- fprintf(stderr, "ERROR: open %s failed. %s\n", si->path,
253 -+ fprintf(stderr, "ERROR: open %s failed. %s\n", subvol,
254 - strerror(-ret));
255 - goto out;
256 - }
257 -@@ -385,10 +375,6 @@ out:
258 - close(pipefd[0]);
259 - if (pipefd[1] != -1)
260 - close(pipefd[1]);
261 -- if (si) {
262 -- free(si->path);
263 -- free(si);
264 -- }
265 - return ret;
266 - }
267 -
268 -@@ -664,14 +650,6 @@ int cmd_send(int argc, char **argv)
269 - goto out;
270 - }
271 -
272 -- ret = get_root_id(&send, get_subvol_name(send.root_path, subvol),
273 -- &root_id);
274 -- if (ret < 0) {
275 -- fprintf(stderr, "ERROR: could not resolve root_id "
276 -- "for %s\n", subvol);
277 -- goto out;
278 -- }
279 --
280 - if (!full_send && !parent_root_id) {
281 - ret = find_good_parent(&send, root_id, &parent_root_id);
282 - if (ret < 0) {
283 -@@ -700,8 +678,8 @@ int cmd_send(int argc, char **argv)
284 - is_first_subvol = 1;
285 - is_last_subvol = 1;
286 - }
287 -- ret = do_send(&send, root_id, parent_root_id,
288 -- is_first_subvol, is_last_subvol);
289 -+ ret = do_send(&send, parent_root_id, is_first_subvol,
290 -+ is_last_subvol, subvol);
291 - if (ret < 0)
292 - goto out;
293 -
294 ---
295 -1.8.4
296 -
297 ---
298 -To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
299 -the body of a message to majordomo@×××××××××××.org
300 -More majordomo info at http://vger.kernel.org/majordomo-info.html
301
302 diff --git a/sys-fs/btrfs-progs/files/btrfs-progs-3.14.1-arg_strtou64.patch b/sys-fs/btrfs-progs/files/btrfs-progs-3.14.1-arg_strtou64.patch
303 deleted file mode 100644
304 index a9cced815b..0000000000
305 --- a/sys-fs/btrfs-progs/files/btrfs-progs-3.14.1-arg_strtou64.patch
306 +++ /dev/null
307 @@ -1,146 +0,0 @@
308 -From: David Sterba <dsterba@××××.cz>
309 -To: linux-btrfs@×××××××××××.org
310 -Subject: [PATCH v2] btrfs-progs: move arg_strtou64 to a separate file for library
311 -Date: Tue, 22 Apr 2014 17:49:01 +0200
312 -
313 -Linking with libbtrfs fails because arg_strtou64 is not defined and we
314 -cannot just add utils.o to library objects because it's not
315 -library-clean.
316 -
317 -Reported-by: Arvin Schnell <aschnell@××××.com>
318 -Reported-by: Anton Farygin <rider@××××××××.org>
319 -Signed-off-by: David Sterba <dsterba@××××.cz>
320 ----
321 -
322 -v2: (thanks to Hugo)
323 -- added missing line from comment
324 -- fixed typo
325 -- reformated comment paragraphs
326 -
327 - Makefile | 5 +++--
328 - utils-lib.c | 42 ++++++++++++++++++++++++++++++++++++++++++
329 - utils.c | 33 ---------------------------------
330 - 3 files changed, 45 insertions(+), 35 deletions(-)
331 - create mode 100644 utils-lib.c
332 -
333 -diff --git a/Makefile b/Makefile
334 -index 51d53fadf5af..76565e8b2307 100644
335 ---- a/Makefile
336 -+++ b/Makefile
337 -@@ -9,14 +9,15 @@ CFLAGS = -g -O1 -fno-strict-aliasing
338 - objects = ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o \
339 - root-tree.o dir-item.o file-item.o inode-item.o inode-map.o \
340 - extent-cache.o extent_io.o volumes.o utils.o repair.o \
341 -- qgroup.o raid6.o free-space-cache.o list_sort.o props.o
342 -+ qgroup.o raid6.o free-space-cache.o list_sort.o props.o \
343 -+ utils-lib.o
344 - cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \
345 - cmds-inspect.o cmds-balance.o cmds-send.o cmds-receive.o \
346 - cmds-quota.o cmds-qgroup.o cmds-replace.o cmds-check.o \
347 - cmds-restore.o cmds-rescue.o chunk-recover.o super-recover.o \
348 - cmds-property.o
349 - libbtrfs_objects = send-stream.o send-utils.o rbtree.o btrfs-list.o crc32c.o \
350 -- uuid-tree.o
351 -+ uuid-tree.o utils-lib.o
352 - libbtrfs_headers = send-stream.h send-utils.h send.h rbtree.h btrfs-list.h \
353 - crc32c.h list.h kerncompat.h radix-tree.h extent-cache.h \
354 - extent_io.h ioctl.h ctree.h btrfsck.h
355 -diff --git a/utils-lib.c b/utils-lib.c
356 -new file mode 100644
357 -index 000000000000..9d53c6e5c710
358 ---- /dev/null
359 -+++ b/utils-lib.c
360 -@@ -0,0 +1,42 @@
361 -+#define _GNU_SOURCE
362 -+
363 -+#include "kerncompat.h"
364 -+#include <unistd.h>
365 -+#include <stdlib.h>
366 -+#include <limits.h>
367 -+
368 -+#if BTRFS_FLAT_INCLUDES
369 -+#else
370 -+#endif /* BTRFS_FLAT_INCLUDES */
371 -+
372 -+/*
373 -+ * This function should be only used when parsing command arg, it won't return
374 -+ * error to its caller and rather exit directly just like usage().
375 -+ */
376 -+u64 arg_strtou64(const char *str)
377 -+{
378 -+ u64 value;
379 -+ char *ptr_parse_end = NULL;
380 -+
381 -+ value = strtoull(str, &ptr_parse_end, 0);
382 -+ if (ptr_parse_end && *ptr_parse_end != '\0') {
383 -+ fprintf(stderr, "ERROR: %s is not a valid numeric value.\n",
384 -+ str);
385 -+ exit(1);
386 -+ }
387 -+
388 -+ /*
389 -+ * if we pass a negative number to strtoull, it will return an
390 -+ * unexpected number to us, so let's do the check ourselves.
391 -+ */
392 -+ if (str[0] == '-') {
393 -+ fprintf(stderr, "ERROR: %s: negative value is invalid.\n",
394 -+ str);
395 -+ exit(1);
396 -+ }
397 -+ if (value == ULLONG_MAX) {
398 -+ fprintf(stderr, "ERROR: %s is too large.\n", str);
399 -+ exit(1);
400 -+ }
401 -+ return value;
402 -+}
403 -diff --git a/utils.c b/utils.c
404 -index 29953d9dd2a9..e130849c7bb5 100644
405 ---- a/utils.c
406 -+++ b/utils.c
407 -@@ -1538,39 +1538,6 @@ scan_again:
408 - return 0;
409 - }
410 -
411 --/*
412 -- * This function should be only used when parsing
413 -- * command arg, it won't return error to it's
414 -- * caller and rather exit directly just like usage().
415 -- */
416 --u64 arg_strtou64(const char *str)
417 --{
418 -- u64 value;
419 -- char *ptr_parse_end = NULL;
420 --
421 -- value = strtoull(str, &ptr_parse_end, 0);
422 -- if (ptr_parse_end && *ptr_parse_end != '\0') {
423 -- fprintf(stderr, "ERROR: %s is not a valid numeric value.\n",
424 -- str);
425 -- exit(1);
426 -- }
427 -- /*
428 -- * if we pass a negative number to strtoull,
429 -- * it will return an unexpected number to us,
430 -- * so let's do the check ourselves.
431 -- */
432 -- if (str[0] == '-') {
433 -- fprintf(stderr, "ERROR: %s: negative value is invalid.\n",
434 -- str);
435 -- exit(1);
436 -- }
437 -- if (value == ULLONG_MAX) {
438 -- fprintf(stderr, "ERROR: %s is too large.\n", str);
439 -- exit(1);
440 -- }
441 -- return value;
442 --}
443 --
444 - u64 parse_size(char *s)
445 - {
446 - int i;
447 ---
448 -1.9.0
449 -
450 ---
451 -To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
452 -the body of a message to majordomo@×××××××××××.org
453 -More majordomo info at http://vger.kernel.org/majordomo-info.html