| 1 |
commit: 4a879481536068780fda845e214f5f6f28128860 |
| 2 |
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Wed Sep 5 20:43:42 2018 +0000 |
| 4 |
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Wed Sep 5 21:06:41 2018 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a879481 |
| 7 |
|
| 8 |
media-sound/beets: Remove USE flac,ogg,opus; fix USE gstreamer |
| 9 |
|
| 10 |
They were effectively only used if USE +replaygain +gstreamer were enabled, |
| 11 |
not ticking any build switches but purely forwarding USE dependencies. |
| 12 |
Depend on media-plugins/gst-plugins-meta instead. |
| 13 |
|
| 14 |
gstreamer is also being used if USE +mpd. |
| 15 |
|
| 16 |
Reviewed-by: Mart Raudsepp <leio <AT> gentoo.org> |
| 17 |
|
| 18 |
Quote: |
| 19 |
replaygain uses decodebin, thus should depend on |
| 20 |
media-plugins/gst-plugins-meta:1.0 to pull in any decided by user decoders. |
| 21 |
It uses rganalysis explicitly, for which it needs to depend on |
| 22 |
media-libs/gst-plugins-good:1.0. Other explicitly used elements are all |
| 23 |
from core or base, thus the gst-plugins-meta dep will cover it, or you can |
| 24 |
be explicit (core = media-libs/gstreamer). |
| 25 |
|
| 26 |
Additionally there is beetsplug/bpd/gstplayer.py that uses playbin. I don't |
| 27 |
know what that thing is about, but it seems irrelevant to replaygain, so |
| 28 |
might want a gstreamer? ( media-plugins/gst-plugins-meta:1.0 ) independent |
| 29 |
of USE=replaygain, if it's optional enough to work fine without it |
| 30 |
installed without losing anything important. |
| 31 |
|
| 32 |
Package-Manager: Portage-2.3.49, Repoman-2.3.10 |
| 33 |
|
| 34 |
media-sound/beets/beets-1.4.7.ebuild | 8 +++----- |
| 35 |
1 file changed, 3 insertions(+), 5 deletions(-) |
| 36 |
|
| 37 |
diff --git a/media-sound/beets/beets-1.4.7.ebuild b/media-sound/beets/beets-1.4.7.ebuild |
| 38 |
index 7a21e504abd..b0ea1935a00 100644 |
| 39 |
--- a/media-sound/beets/beets-1.4.7.ebuild |
| 40 |
+++ b/media-sound/beets/beets-1.4.7.ebuild |
| 41 |
@@ -17,7 +17,7 @@ HOMEPAGE="http://beets.io/ https://pypi.org/project/beets/" |
| 42 |
KEYWORDS="~amd64 ~x86" |
| 43 |
SLOT="0" |
| 44 |
LICENSE="MIT" |
| 45 |
-IUSE="badfiles chromaprint doc discogs ffmpeg flac gstreamer lastfm mpd ogg opus replaygain test thumbnail webserver" |
| 46 |
+IUSE="badfiles chromaprint doc discogs ffmpeg gstreamer lastfm mpd replaygain test thumbnail webserver" |
| 47 |
|
| 48 |
RDEPEND=" |
| 49 |
dev-python/jellyfish[${PYTHON_USEDEP}] |
| 50 |
@@ -45,15 +45,13 @@ RDEPEND=" |
| 51 |
mpd? ( |
| 52 |
dev-python/bluelet[${PYTHON_USEDEP}] |
| 53 |
dev-python/python-mpd[${PYTHON_USEDEP}] |
| 54 |
+ gstreamer? ( media-plugins/gst-plugins-meta:1.0 ) |
| 55 |
) |
| 56 |
replaygain? ( |
| 57 |
gstreamer? ( |
| 58 |
dev-python/pygobject:3[${PYTHON_USEDEP}] |
| 59 |
- media-libs/gstreamer:1.0[introspection] |
| 60 |
- media-libs/gst-plugins-base:1.0[ogg?] |
| 61 |
media-libs/gst-plugins-good:1.0 |
| 62 |
- flac? ( media-plugins/gst-plugins-flac:1.0 ) |
| 63 |
- opus? ( media-plugins/gst-plugins-opus:1.0 ) |
| 64 |
+ media-plugins/gst-plugins-meta:1.0 |
| 65 |
) |
| 66 |
!gstreamer? ( media-sound/mp3gain ) |
| 67 |
) |
Archives