Gentoo Archives: gentoo-commits

From: James Le Cuirot <chewi@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: app-arch/unarj/files/, app-arch/unarj/
Date: Mon, 12 Oct 2020 21:14:03
Message-Id: 1602537193.b3247af81789446309b23bef68ccd5e5842cc04d.chewi@gentoo
1 commit: b3247af81789446309b23bef68ccd5e5842cc04d
2 Author: James Le Cuirot <chewi <AT> gentoo <DOT> org>
3 AuthorDate: Mon Oct 12 21:10:41 2020 +0000
4 Commit: James Le Cuirot <chewi <AT> gentoo <DOT> org>
5 CommitDate: Mon Oct 12 21:13:13 2020 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3247af8
7
8 app-arch/unarj: Remove last-rited package
9
10 Closes: https://bugs.gentoo.org/694746
11 Signed-off-by: James Le Cuirot <chewi <AT> gentoo.org>
12
13 app-arch/unarj/Manifest | 1 -
14 .../unarj/files/unarj-2.65-CAN-2004-0947.patch | 49 --------
15 .../unarj/files/unarj-2.65-Wformat-security.patch | 66 -----------
16 app-arch/unarj/files/unarj-2.65-gentoo-fbsd.patch | 10 --
17 app-arch/unarj/files/unarj-2.65-sanitation.patch | 126 ---------------------
18 app-arch/unarj/metadata.xml | 5 -
19 app-arch/unarj/unarj-2.65.ebuild | 31 -----
20 7 files changed, 288 deletions(-)
21
22 diff --git a/app-arch/unarj/Manifest b/app-arch/unarj/Manifest
23 deleted file mode 100644
24 index cd694c267a0..00000000000
25 --- a/app-arch/unarj/Manifest
26 +++ /dev/null
27 @@ -1 +0,0 @@
28 -DIST unarj-2.65.tgz 21568 BLAKE2B 9b4d15782ebbac841937fc30c049e300d4c4324cb0cd7a585a228454ee35e7177e73cb6523e6cd03a509f9ad20103790ce3eac77552956557290414d57af2bdd SHA512 1b152063017042a343f49e487e5284c3d4c548222baa52e2066cefe6d2add60213ffd2653f42e38582681a1fd89efb8f1d3a6ef6389fc33e5397760ad9e72386
29
30 diff --git a/app-arch/unarj/files/unarj-2.65-CAN-2004-0947.patch b/app-arch/unarj/files/unarj-2.65-CAN-2004-0947.patch
31 deleted file mode 100644
32 index f52af83ac2c..00000000000
33 --- a/app-arch/unarj/files/unarj-2.65-CAN-2004-0947.patch
34 +++ /dev/null
35 @@ -1,49 +0,0 @@
36 -Index: unarj-2.65/unarj.c
37 -===================================================================
38 ---- unarj-2.65.orig/unarj.c
39 -+++ unarj-2.65/unarj.c
40 -@@ -217,7 +217,7 @@ static uchar arj_flags;
41 - static short method;
42 - static uint file_mode;
43 - static ulong time_stamp;
44 --static short entry_pos;
45 -+static ushort entry_pos;
46 - static ushort host_data;
47 - static uchar *get_ptr;
48 - static UCRC file_crc;
49 -@@ -608,6 +608,7 @@ char *name;
50 - error(M_BADHEADR, "");
51 -
52 - crc = CRC_MASK;
53 -+ memset(header, 0, sizeof(header));
54 - fread_crc(header, (int) headersize, fd);
55 - header_crc = fget_crc(fd);
56 - if ((crc ^ CRC_MASK) != header_crc)
57 -@@ -632,9 +633,13 @@ char *name;
58 -
59 - if (origsize < 0 || compsize < 0)
60 - error(M_HEADRCRC, "");
61 -+ if(first_hdr_size > headersize-2) /* need two \0 for file and comment */
62 -+ error(M_BADHEADR, "");
63 -
64 - hdr_filename = (char *)&header[first_hdr_size];
65 - strncopy(filename, hdr_filename, sizeof(filename));
66 -+ if(entry_pos >= strlen(filename))
67 -+ error(M_BADHEADR, "");
68 - if (host_os != OS)
69 - strparity((uchar *)filename);
70 - if ((arj_flags & PATHSYM_FLAG) != 0)
71 -@@ -733,11 +738,11 @@ extract()
72 -
73 - no_output = 0;
74 - if (command == 'E')
75 -- strcpy(name, &filename[entry_pos]);
76 -+ strncopy(name, &filename[entry_pos], sizeof(name));
77 - else
78 - {
79 - strcpy(name, DEFAULT_DIR);
80 -- strcat(name, filename);
81 -+ strncopy(name+strlen(name), filename, sizeof(name)-strlen(name));
82 - }
83 -
84 - if (host_os != OS)
85
86 diff --git a/app-arch/unarj/files/unarj-2.65-Wformat-security.patch b/app-arch/unarj/files/unarj-2.65-Wformat-security.patch
87 deleted file mode 100644
88 index a076dd91f13..00000000000
89 --- a/app-arch/unarj/files/unarj-2.65-Wformat-security.patch
90 +++ /dev/null
91 @@ -1,66 +0,0 @@
92 -Bug: https://bugs.gentoo.org/520478
93 -
94 ---- a/unarj.c
95 -+++ b/unarj.c
96 -@@ -699,7 +699,7 @@
97 - }
98 - if ((arj_flags & GARBLE_FLAG) != 0)
99 - {
100 -- printf(M_ENCRYPT);
101 -+ puts(M_ENCRYPT);
102 - printf(M_SKIPPED, filename);
103 - skip();
104 - return -1;
105 -@@ -763,7 +763,7 @@
106 - }
107 - printf(M_EXTRACT, name);
108 - if (host_os != OS && file_type == BINARY_TYPE)
109 -- printf(M_DIFFHOST);
110 -+ puts(M_DIFFHOST);
111 - printf(" ");
112 -
113 - crc = CRC_MASK;
114 -@@ -779,10 +779,10 @@
115 - set_ftime_mode(name, time_stamp, file_mode, (uint) host_os);
116 -
117 - if ((crc ^ CRC_MASK) == file_crc)
118 -- printf(M_CRCOK);
119 -+ puts(M_CRCOK);
120 - else
121 - {
122 -- printf(M_CRCERROR);
123 -+ puts(M_CRCERROR);
124 - error_count++;
125 - }
126 - return 1;
127 -@@ -808,10 +808,10 @@
128 - decode_f();
129 -
130 - if ((crc ^ CRC_MASK) == file_crc)
131 -- printf(M_CRCOK);
132 -+ puts(M_CRCOK);
133 - else
134 - {
135 -- printf(M_CRCERROR);
136 -+ puts(M_CRCERROR);
137 - error_count++;
138 - }
139 - return 1;
140 -@@ -958,7 +958,7 @@
141 - int i;
142 -
143 - for (i = 0; M_USAGE[i] != NULL; i++)
144 -- printf(M_USAGE[i]);
145 -+ puts(M_USAGE[i]);
146 - }
147 -
148 - int
149 -@@ -973,7 +973,7 @@
150 - argc = ccommand(&argv);
151 - #endif
152 -
153 -- printf(M_VERSION);
154 -+ puts(M_VERSION);
155 -
156 - if (argc == 1)
157 - {
158
159 diff --git a/app-arch/unarj/files/unarj-2.65-gentoo-fbsd.patch b/app-arch/unarj/files/unarj-2.65-gentoo-fbsd.patch
160 deleted file mode 100644
161 index 171b9959f43..00000000000
162 --- a/app-arch/unarj/files/unarj-2.65-gentoo-fbsd.patch
163 +++ /dev/null
164 @@ -1,10 +0,0 @@
165 ---- a/environ.c
166 -+++ b/environ.c
167 -@@ -437,7 +437,6 @@
168 - #endif
169 -
170 - extern struct tm *localtime();
171 --extern time_t time();
172 - extern char *strcpy();
173 - extern voidp *malloc();
174 -
175
176 diff --git a/app-arch/unarj/files/unarj-2.65-sanitation.patch b/app-arch/unarj/files/unarj-2.65-sanitation.patch
177 deleted file mode 100644
178 index f37784ed249..00000000000
179 --- a/app-arch/unarj/files/unarj-2.65-sanitation.patch
180 +++ /dev/null
181 @@ -1,126 +0,0 @@
182 -Index: unarj-2.65/sanitize.c
183 -===================================================================
184 ---- /dev/null
185 -+++ unarj-2.65/sanitize.c
186 -@@ -0,0 +1,81 @@
187 -+/*
188 -+ * Path sanitation code by Ludwig Nussel <ludwig.nussel@××××.de>. Public Domain.
189 -+ */
190 -+
191 -+#include "unarj.h"
192 -+
193 -+#include <string.h>
194 -+#include <limits.h>
195 -+#include <stdio.h>
196 -+
197 -+#ifndef PATH_CHAR
198 -+#define PATH_CHAR '/'
199 -+#endif
200 -+#ifndef MIN
201 -+#define MIN(x,y) ((x)<(y)?(x):(y))
202 -+#endif
203 -+
204 -+/* copy src into dest converting the path to a relative one inside the current
205 -+ * directory. dest must hold at least len bytes */
206 -+void copy_path_relative(char *dest, char *src, size_t len)
207 -+{
208 -+ char* o = dest;
209 -+ char* p = src;
210 -+
211 -+ *o = '\0';
212 -+
213 -+ while(*p && *p == PATH_CHAR) ++p;
214 -+ for(; len && *p;)
215 -+ {
216 -+ src = p;
217 -+ p = strchr(src, PATH_CHAR);
218 -+ if(!p) p = src+strlen(src);
219 -+
220 -+ /* . => skip */
221 -+ if(p-src == 1 && *src == '.' )
222 -+ {
223 -+ if(*p) src = ++p;
224 -+ }
225 -+ /* .. => pop one */
226 -+ else if(p-src == 2 && *src == '.' && src[1] == '.')
227 -+ {
228 -+ if(o != dest)
229 -+ {
230 -+ char* tmp;
231 -+ *o = '\0';
232 -+ tmp = strrchr(dest, PATH_CHAR);
233 -+ if(!tmp)
234 -+ {
235 -+ len += o-dest;
236 -+ o = dest;
237 -+ if(*p) ++p;
238 -+ }
239 -+ else
240 -+ {
241 -+ len += o-tmp;
242 -+ o = tmp;
243 -+ if(*p) ++p;
244 -+ }
245 -+ }
246 -+ else /* nothing to pop */
247 -+ if(*p) ++p;
248 -+ }
249 -+ else
250 -+ {
251 -+ size_t copy;
252 -+ if(o != dest)
253 -+ {
254 -+ --len;
255 -+ *o++ = PATH_CHAR;
256 -+ }
257 -+ copy = MIN(p-src,len);
258 -+ memcpy(o, src, copy);
259 -+ len -= copy;
260 -+ src += copy;
261 -+ o += copy;
262 -+ if(*p) ++p;
263 -+ }
264 -+ while(*p && *p == PATH_CHAR) ++p;
265 -+ }
266 -+ o[len?0:-1] = '\0';
267 -+}
268 -Index: unarj-2.65/unarj.c
269 -===================================================================
270 ---- unarj-2.65.orig/unarj.c
271 -+++ unarj-2.65/unarj.c
272 -@@ -235,6 +235,8 @@ static UCRC crctable[UCHAR_MAX + 1];
273 -
274 - /* Functions */
275 -
276 -+void copy_path_relative(char *dest, char *src, size_t len);
277 -+
278 - static void
279 - make_crctable()
280 - {
281 -@@ -738,11 +740,11 @@ extract()
282 -
283 - no_output = 0;
284 - if (command == 'E')
285 -- strncopy(name, &filename[entry_pos], sizeof(name));
286 -+ copy_path_relative(name, &filename[entry_pos], sizeof(name));
287 - else
288 - {
289 - strcpy(name, DEFAULT_DIR);
290 -- strncopy(name+strlen(name), filename, sizeof(name)-strlen(name));
291 -+ copy_path_relative(name+strlen(name), filename, sizeof(name)-strlen(name));
292 - }
293 -
294 - if (host_os != OS)
295 ---- unarj-2.65.orig/Makefile Mon Nov 29 16:47:24 2004
296 -+++ unarj-2.65/Makefile Mon Nov 29 22:46:56 2004
297 -@@ -9,7 +9,9 @@
298 -
299 - decode.o: decode.c unarj.h
300 -
301 --OBJS = unarj.o decode.o environ.o
302 -+sanitize.o: sanitize.c unarj.h
303 -+
304 -+OBJS = unarj.o decode.o environ.o sanitize.o
305 -
306 - unarj: $(OBJS)
307 - $(CC) $(LDFLAGS) $(OBJS) -o unarj
308
309 diff --git a/app-arch/unarj/metadata.xml b/app-arch/unarj/metadata.xml
310 deleted file mode 100644
311 index 1b2becffa26..00000000000
312 --- a/app-arch/unarj/metadata.xml
313 +++ /dev/null
314 @@ -1,5 +0,0 @@
315 -<?xml version="1.0" encoding="UTF-8"?>
316 -<!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
317 -<pkgmetadata>
318 - <!-- maintainer-needed -->
319 -</pkgmetadata>
320
321 diff --git a/app-arch/unarj/unarj-2.65.ebuild b/app-arch/unarj/unarj-2.65.ebuild
322 deleted file mode 100644
323 index ccd1ce99ae1..00000000000
324 --- a/app-arch/unarj/unarj-2.65.ebuild
325 +++ /dev/null
326 @@ -1,31 +0,0 @@
327 -# Copyright 1999-2020 Gentoo Authors
328 -# Distributed under the terms of the GNU General Public License v2
329 -
330 -EAPI=6
331 -
332 -inherit toolchain-funcs
333 -
334 -DESCRIPTION="Utility for opening arj archives"
335 -HOMEPAGE="http://www.arjsoftware.com/"
336 -SRC_URI="mirror://gentoo/${P}.tgz"
337 -
338 -LICENSE="arj"
339 -SLOT="0"
340 -KEYWORDS="~alpha amd64 arm hppa ~ia64 ppc ppc64 sparc x86 ~amd64-linux ~x86-linux ~ppc-macos ~sparc-solaris ~x86-solaris"
341 -IUSE=""
342 -
343 -PATCHES=(
344 - "${FILESDIR}"/${P}-CAN-2004-0947.patch
345 - "${FILESDIR}"/${P}-sanitation.patch
346 - "${FILESDIR}"/${P}-gentoo-fbsd.patch
347 - "${FILESDIR}"/${PN}-2.65-Wformat-security.patch
348 -)
349 -
350 -src_configure() {
351 - tc-export CC
352 -}
353 -
354 -src_install() {
355 - dobin unarj
356 - dodoc unarj.txt technote.txt
357 -}