Gentoo Archives: gentoo-commits

From: Nirbheek Chauhan <nirbheek@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/gnome:master commit in: gnome-base/gnome-desktop/, gnome-base/gnome-desktop/files/
Date: Mon, 02 May 2011 15:56:41
Message-Id: c249b133b6ecf094bf9e1a23b37a33c0497acc31.nirbheek@gentoo
1 commit: c249b133b6ecf094bf9e1a23b37a33c0497acc31
2 Author: Nirbheek Chauhan <nirbheek <AT> gentoo <DOT> org>
3 AuthorDate: Mon May 2 15:54:43 2011 +0000
4 Commit: Nirbheek Chauhan <nirbheek <AT> gentoo <DOT> org>
5 CommitDate: Mon May 2 15:54:43 2011 +0000
6 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=commit;h=c249b133
7
8 gnome-base/gnome-desktop: fix bug 365717
9
10 ---
11 ...ome-desktop-3.0.1-fix-randr-missing-crash.patch | 30 ++++++++++++++++++++
12 ...-3.0.1.ebuild => gnome-desktop-3.0.1-r1.ebuild} | 6 ++++
13 2 files changed, 36 insertions(+), 0 deletions(-)
14
15 diff --git a/gnome-base/gnome-desktop/files/gnome-desktop-3.0.1-fix-randr-missing-crash.patch b/gnome-base/gnome-desktop/files/gnome-desktop-3.0.1-fix-randr-missing-crash.patch
16 new file mode 100644
17 index 0000000..5402a20
18 --- /dev/null
19 +++ b/gnome-base/gnome-desktop/files/gnome-desktop-3.0.1-fix-randr-missing-crash.patch
20 @@ -0,0 +1,30 @@
21 +From aa93854f2ba6b0f72f1bdff9699b5724a72c89c9 Mon Sep 17 00:00:00 2001
22 +From: Matthias Clasen <mclasen@××××××.com>
23 +Date: Sat, 30 Apr 2011 20:48:03 -0400
24 +Subject: [PATCH] Don't fall over if RANDR is missing
25 +
26 +When RANDR is not present, the screen object never gets an info,
27 +and since screen_info_free asserts, we must not call it unconditionally
28 +in finalize.
29 +This fixes https://bugzilla.gnome.org/show_bug.cgi?id=649053
30 +---
31 + libgnome-desktop/gnome-rr.c | 3 ++-
32 + 1 files changed, 2 insertions(+), 1 deletions(-)
33 +
34 +diff --git a/libgnome-desktop/gnome-rr.c b/libgnome-desktop/gnome-rr.c
35 +index 4a9d98e..eb3d735 100644
36 +--- a/libgnome-desktop/gnome-rr.c
37 ++++ b/libgnome-desktop/gnome-rr.c
38 +@@ -748,7 +748,8 @@ gnome_rr_screen_finalize (GObject *gobject)
39 +
40 + gdk_window_remove_filter (screen->priv->gdk_root, screen_on_event, screen);
41 +
42 +- screen_info_free (screen->priv->info);
43 ++ if (screen->priv->info)
44 ++ screen_info_free (screen->priv->info);
45 +
46 + G_OBJECT_CLASS (gnome_rr_screen_parent_class)->finalize (gobject);
47 + }
48 +--
49 +1.7.5
50 +
51
52 diff --git a/gnome-base/gnome-desktop/gnome-desktop-3.0.1.ebuild b/gnome-base/gnome-desktop/gnome-desktop-3.0.1-r1.ebuild
53 similarity index 92%
54 rename from gnome-base/gnome-desktop/gnome-desktop-3.0.1.ebuild
55 rename to gnome-base/gnome-desktop/gnome-desktop-3.0.1-r1.ebuild
56 index 87d2013..fce1620 100644
57 --- a/gnome-base/gnome-desktop/gnome-desktop-3.0.1.ebuild
58 +++ b/gnome-base/gnome-desktop/gnome-desktop-3.0.1-r1.ebuild
59 @@ -58,3 +58,9 @@ pkg_setup() {
60 $(use_enable doc desktop-docs)
61 $(use_enable introspection)"
62 }
63 +
64 +src_prepare() {
65 + # https://bugs.gentoo.org/show_bug.cgi?id=365717
66 + epatch "${FILESDIR}/${P}-fix-randr-missing-crash.patch"
67 + gnome2_src_prepare
68 +}