1 |
commit: 290bbd89e17c723ca268f36ed01d2256c372a015 |
2 |
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
3 |
AuthorDate: Mon Jan 28 19:29:12 2019 +0000 |
4 |
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org> |
5 |
CommitDate: Mon Jan 28 22:34:42 2019 +0000 |
6 |
URL: https://gitweb.gentoo.org/proj/kde.git/commit/?id=290bbd89 |
7 |
|
8 |
kde5.eclass: Relocate KDE_INSTALL_DOCBUNDLEDIR to /usr/share/help |
9 |
|
10 |
These are handbook files installed by hundreds of packages to a |
11 |
central location, to be accessed by KDE Helpcenter application, |
12 |
with compressed index cache files. |
13 |
|
14 |
This leads to the following QA issues on every package w/ USE handbook: |
15 |
* The ebuild is installing to one or more unexpected paths |
16 |
* One or more compressed files were found in docompress-ed directories |
17 |
|
18 |
We'll use the EAPI-7 transition to move the location from previously |
19 |
/usr/share/doc/HTML to /usr/share/help [1]. Transition for khelpcenter |
20 |
will be seemless as kde-frameworks/kdoctools can be easily patched to |
21 |
accept both locations, until eventually /usr/share/doc/HTML is empty. |
22 |
|
23 |
As a side-effect, we will be able to drop the workaround for disabling |
24 |
auto compression of files beneath /usr/share/doc together with EAPI-6. |
25 |
|
26 |
[1] See also: https://www.freedesktop.org/wiki/Specifications/help-system/ |
27 |
It is also the path upstream intends to migrate to in the future. |
28 |
|
29 |
Bug: https://bugs.gentoo.org/667138 |
30 |
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org> |
31 |
|
32 |
eclass/kde5.eclass | 14 +++++++++----- |
33 |
1 file changed, 9 insertions(+), 5 deletions(-) |
34 |
|
35 |
diff --git a/eclass/kde5.eclass b/eclass/kde5.eclass |
36 |
index d6c790fe52..b25679a76c 100644 |
37 |
--- a/eclass/kde5.eclass |
38 |
+++ b/eclass/kde5.eclass |
39 |
@@ -636,6 +636,8 @@ kde5_src_configure() { |
40 |
# install mkspecs in the same directory as qt stuff |
41 |
-DKDE_INSTALL_USE_QT_SYS_PATHS=ON |
42 |
) |
43 |
+ # move handbook outside of doc dir for at least two QA warnings, bug 667138 |
44 |
+ [[ ${EAPI} != 6 ]] && cmakeargs+=( -DKDE_INSTALL_DOCBUNDLEDIR="${EPREFIX}/usr/share/help" ) |
45 |
fi |
46 |
|
47 |
# allow the ebuild to override what we set here |
48 |
@@ -705,11 +707,13 @@ kde5_src_install() { |
49 |
docompress -x /usr/share/doc/qt-${pv} |
50 |
fi |
51 |
|
52 |
- # We don't want /usr/share/doc/HTML to be compressed, |
53 |
- # because then khelpcenter can't find the docs |
54 |
- #todo: clean up trailing slash check when EAPI <7 is removed |
55 |
- if [[ -d ${ED%/}/usr/share/doc/HTML ]]; then |
56 |
- docompress -x /usr/share/doc/HTML |
57 |
+ if [[ ${EAPI} = 6 ]]; then |
58 |
+ # We don't want /usr/share/doc/HTML to be compressed, |
59 |
+ # because then khelpcenter can't find the docs |
60 |
+ #todo: clean up trailing slash check when EAPI <7 is removed |
61 |
+ if [[ -d ${ED%/}/usr/share/doc/HTML ]]; then |
62 |
+ docompress -x /usr/share/doc/HTML |
63 |
+ fi |
64 |
fi |
65 |
} |