Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-plasma/khotkeys/, kde-plasma/khotkeys/files/
Date: Sat, 22 Jul 2017 07:36:31
Message-Id: 1500708977.cdcbaf25b1e164c0dd087443e282453cdf6748d0.asturm@gentoo
1 commit: cdcbaf25b1e164c0dd087443e282453cdf6748d0
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Sat Jul 22 07:33:46 2017 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Sat Jul 22 07:36:17 2017 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cdcbaf25
7
8 kde-plasma/khotkeys: Fix build with cmake-3.9
9
10 Reported-by: Perfect Gentleman <perfect007gentleman <AT> gmail.com>
11 Gentoo-bug: 625744
12
13 Package-Manager: Portage-2.3.6, Repoman-2.3.1
14
15 .../khotkeys/files/khotkeys-5.10.4-cmake-3.9.patch | 60 ++++++++++++++++++++++
16 kde-plasma/khotkeys/khotkeys-5.10.4.ebuild | 2 +
17 2 files changed, 62 insertions(+)
18
19 diff --git a/kde-plasma/khotkeys/files/khotkeys-5.10.4-cmake-3.9.patch b/kde-plasma/khotkeys/files/khotkeys-5.10.4-cmake-3.9.patch
20 new file mode 100644
21 index 00000000000..541a184ec8d
22 --- /dev/null
23 +++ b/kde-plasma/khotkeys/files/khotkeys-5.10.4-cmake-3.9.patch
24 @@ -0,0 +1,60 @@
25 +From db3a04289d0f33285c3ca2d8fc05fc5bb45d608f Mon Sep 17 00:00:00 2001
26 +From: Heiko Becker <heirecka@×××××××.org>
27 +Date: Wed, 19 Jul 2017 22:28:32 +0200
28 +Subject: Make sure the dbus xml interface file exists before it's used
29 +
30 +Summary:
31 +This started to happen with cmake 3.9, producing this erorr:
32 +*** No rule to make target 'app/org.kde.khotkeys.xml', needed by
33 +'kcm_hotkeys/khotkeys_interface.cpp'."
34 +
35 +Test Plan: Builds fine with cmake 3.9.
36 +
37 +Reviewers: #plasma
38 +
39 +Subscribers: plasma-devel
40 +
41 +Tags: #plasma
42 +
43 +Differential Revision: https://phabricator.kde.org/D6792
44 +---
45 + app/CMakeLists.txt | 8 ++++++--
46 + kcm_hotkeys/CMakeLists.txt | 1 +
47 + 2 files changed, 7 insertions(+), 2 deletions(-)
48 +
49 +diff --git a/app/CMakeLists.txt b/app/CMakeLists.txt
50 +index 0e6609f..2c1485e 100644
51 +--- a/app/CMakeLists.txt
52 ++++ b/app/CMakeLists.txt
53 +@@ -1,10 +1,14 @@
54 + ########### next target ###############
55 +
56 ++set(dbus_interface_name org.kde.khotkeys.xml)
57 + set(kded_khotkeys_PART_SRCS
58 + kded.cpp
59 +- ${CMAKE_CURRENT_BINARY_DIR}/org.kde.khotkeys.xml)
60 ++ ${CMAKE_CURRENT_BINARY_DIR}/${dbus_interface_name})
61 +
62 +-qt5_generate_dbus_interface(kded.h org.kde.khotkeys.xml )
63 ++qt5_generate_dbus_interface(kded.h ${dbus_interface_name})
64 ++set(dbus_interface_xml ${CMAKE_CURRENT_BINARY_DIR}/${dbus_interface_name})
65 ++
66 ++add_custom_target(khotkeysdbusinterface ALL DEPENDS ${dbus_interface_name})
67 +
68 + add_library(kded_khotkeys MODULE ${kded_khotkeys_PART_SRCS})
69 + set_target_properties(kded_khotkeys PROPERTIES OUTPUT_NAME khotkeys)
70 +diff --git a/kcm_hotkeys/CMakeLists.txt b/kcm_hotkeys/CMakeLists.txt
71 +index f0ef3d3..0df2b5c 100644
72 +--- a/kcm_hotkeys/CMakeLists.txt
73 ++++ b/kcm_hotkeys/CMakeLists.txt
74 +@@ -82,6 +82,7 @@ add_library(
75 + MODULE
76 + ${kcm_hotkeys_PART_SRCS}
77 + )
78 ++add_dependencies(kcm_hotkeys khotkeysdbusinterface)
79 +
80 + target_compile_definitions(kcm_hotkeys PRIVATE -DPROJECT_VERSION="${PROJECT_VERSION}")
81 +
82 +--
83 +cgit v0.11.2
84 +
85
86 diff --git a/kde-plasma/khotkeys/khotkeys-5.10.4.ebuild b/kde-plasma/khotkeys/khotkeys-5.10.4.ebuild
87 index 95b8eaf17fd..aab83644404 100644
88 --- a/kde-plasma/khotkeys/khotkeys-5.10.4.ebuild
89 +++ b/kde-plasma/khotkeys/khotkeys-5.10.4.ebuild
90 @@ -44,3 +44,5 @@ DEPEND="${COMMON_DEPEND}
91 x11-libs/libXtst
92 x11-proto/xproto
93 "
94 +
95 +PATCHES=( "${FILESDIR}/${P}-cmake-3.9.patch" )